Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for “The specified child already has a parent” #2545

Conversation

Projects
None yet
5 participants
@shanereid
Copy link
Contributor

commented Oct 11, 2018

Does any other open PR do the same thing?

No.

What issue is this PR fixing?

I haven't created an issue for it, but seems to be the same issue found here:
#2447

Error it fixes is the following, which for me personally occurred when re-rendering with the map with a partially different set of Markers.
For performance reasons in my project on render only markers that are within the specified region are returned with render, with the map re-rendering markers using onRegionChangeComplete. With small changes it is generally fine however I found when animating a region change where a lot of markers change this crash would occur.
This simple change in the java code fixed the issue for me.
screenshot_20181011-105356_dusk

(please link the issue here)

How did you test this PR?

I only have this issue on Android, and I could consistently replicate the crash on a suite of android test devices. After the fix it was easy to confirm that it fixed the issue for me. Also the code snippet is pretty harmless and contained, checks for null and should not introduce any crashes.

@rborn

This comment has been minimized.

Copy link
Collaborator

commented Oct 11, 2018

LGTM @alvelig 🐽

@alvelig alvelig merged commit fc3cf88 into react-native-community:master Oct 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@craigcoles

This comment has been minimized.

Copy link

commented Oct 12, 2018

Massive props @shanereid - and thanks for the speedy merge 🎉

@ShrutiGarg019

This comment has been minimized.

Copy link

commented Dec 16, 2018

Does any other open PR do the same thing?

No.

What issue is this PR fixing?

I haven't created an issue for it, but seems to be the same issue found here:
#2447

Error it fixes is the following, which for me personally occurred when re-rendering with the map with a partially different set of Markers.
For performance reasons in my project on render only markers that are within the specified region are returned with render, with the map re-rendering markers using onRegionChangeComplete. With small changes it is generally fine however I found when animating a region change where a lot of markers change this crash would occur.
This simple change in the java code fixed the issue for me.
screenshot_20181011-105356_dusk

(please link the issue here)

How did you test this PR?

I only have this issue on Android, and I could consistently replicate the crash on a suite of android test devices. After the fix it was easy to confirm that it fixed the issue for me. Also the code snippet is pretty harmless and contained, checks for null and should not introduce any crashes.

I am still facing same issue after this fix too.Any other solution for this??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.