Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move babel-plugin-module-resolver and babel-preset-react-native to devDependencies #2548

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
4 participants
@jmheik
Copy link
Contributor

jmheik commented Oct 12, 2018

Does any other open PR do the same thing?

No.

What issue is this PR fixing?

Babel-plugin-module-resolver and babel-preset-react-native are included as runtime dependencies. As far as I can see they are only referred from .babelrc which is also in .npmignore, so they are not used by end users who install react-native-maps as npm module. However, these deps have quite a lot of transitive dependencies. This PR moves them to devDependencies to spare end users from downloading them and bloating the node_modules.

How did you test this PR?

I have searched the code base, and not found any other use for these two deps than .babelrc, which is excluded from npm published version.

@jmheik

This comment has been minimized.

Copy link
Contributor Author

jmheik commented Oct 22, 2018

What do you think @rborn @alvelig ? This would help cleaning up quite some transitive deps from people's projects as can be seen here https://npm.anvaka.com/#/view/2d/react-native-maps

@alvelig

This comment has been minimized.

Copy link
Collaborator

alvelig commented Oct 22, 2018

I like your idea, @jmheik. @rborn, what do you think?

@todorone

This comment has been minimized.

Copy link
Contributor

todorone commented Nov 8, 2018

These type of dependencies are for sure not suitable for dependencies section.
@rborn Please look if this PR can be merged.

@rborn rborn merged commit aa565cd into react-native-community:master Nov 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rborn

This comment has been minimized.

Copy link
Collaborator

rborn commented Nov 8, 2018

@todorone done, can you add it to the 0.22.1 changelog? 🤗

@rborn

This comment has been minimized.

Copy link
Collaborator

rborn commented Nov 8, 2018

@jmheik ❤️

ryanbourneuk pushed a commit to 3sidedcube/react-native-maps that referenced this pull request Dec 10, 2018

Ryan Bourne
Merge remote-tracking branch 'upstream/master'
* upstream/master: (28 commits)
  Calculate bounding box from region (react-native-community#2615)
  [iOS GoogleMap] Fix animateCamera (react-native-community#2608)
  Fix type definition error (react-native-community#2607)
  [Android] Fix app crash in Android if building found but cannot getActiveLevelIndex (react-native-community#2598)
  Provide a camera system (react-native-community#2563)
  Get visible map bounding box (react-native-community#2571)
  [0.22.1] Release (react-native-community#2574)
  Move dev only deps to devDependencies. (react-native-community#2548)
  Specify how to use Google Maps (react-native-community#2550)
  r2507: remove marker: Attempt to invoke virtual method 'void com.google.android.gms.maps.model.setIcon(com.google.android.gms.maps.model.BitmapDescription)' on a null object reference #: remove marker: Attempt to invoke virtual method 'void com.google.android.gms.maps.model.setIcon(com.google.android.gms.maps.model.BitmapDescription)' on a null object reference (react-native-community#2555)
  update to clarify cacheEnabled is apple maps only
  [0.22.0] Release (react-native-community#2535)
  Fix for “The specified child already has a parent”
  Improve installation docs (react-native-community#2541)
  fix fitToSuppliedMarkers function (react-native-community#2524)
  Performance improvements for tracksViewChanges (react-native-community#2487)
  fix spelling mistakes
  Added flag to make sure that there has an Observer of view.
  hotfix PR react-native-community#2478
  Fix a peer dependencies warning
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.