Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r2507: remove marker: Attempt to invoke virtual method 'void com.goog… #2555

Merged
merged 1 commit into from Oct 22, 2018

Conversation

Projects
None yet
5 participants
@salah-ghanim
Copy link
Collaborator

commented Oct 18, 2018

…le.android.gms.maps.model.setIcon(com.google.android.gms.maps.model.BitmapDescription)' on a null object reference #: remove marker: Attempt to invoke virtual method 'void com.google.android.gms.maps.model.setIcon(com.google.android.gms.maps.model.BitmapDescription)' on a null object reference

  • null check is enough

Does any other open PR do the same thing?

No

What issue is this PR fixing?

#2507

How did you test this PR?

Android
and tested on real device

SalahAldin Ghanim
r2507: remove marker: Attempt to invoke virtual method 'void com.goog…
…le.android.gms.maps.model.setIcon(com.google.android.gms.maps.model.BitmapDescription)' on a null object reference #: remove marker: Attempt to invoke virtual method 'void com.google.android.gms.maps.model.setIcon(com.google.android.gms.maps.model.BitmapDescription)' on a null object reference

  * null check is enough
@jerryjj

This comment has been minimized.

Copy link

commented Oct 22, 2018

This fixed the problem for me at least. Is there a timeline when this could get merged and published?
Thanks!

@rborn rborn merged commit b870c0b into react-native-community:master Oct 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@todorone

This comment has been minimized.

Copy link
Contributor

commented Oct 30, 2018

@salah-ghanim Can You please look at report of problem that appeared as a result of Your commit. Do You have an idea if it could be fixed?
#2507 (comment)

ryanbourneuk pushed a commit to 3sidedcube/react-native-maps that referenced this pull request Dec 10, 2018

Ryan Bourne
Merge remote-tracking branch 'upstream/master'
* upstream/master: (28 commits)
  Calculate bounding box from region (react-native-community#2615)
  [iOS GoogleMap] Fix animateCamera (react-native-community#2608)
  Fix type definition error (react-native-community#2607)
  [Android] Fix app crash in Android if building found but cannot getActiveLevelIndex (react-native-community#2598)
  Provide a camera system (react-native-community#2563)
  Get visible map bounding box (react-native-community#2571)
  [0.22.1] Release (react-native-community#2574)
  Move dev only deps to devDependencies. (react-native-community#2548)
  Specify how to use Google Maps (react-native-community#2550)
  r2507: remove marker: Attempt to invoke virtual method 'void com.google.android.gms.maps.model.setIcon(com.google.android.gms.maps.model.BitmapDescription)' on a null object reference #: remove marker: Attempt to invoke virtual method 'void com.google.android.gms.maps.model.setIcon(com.google.android.gms.maps.model.BitmapDescription)' on a null object reference (react-native-community#2555)
  update to clarify cacheEnabled is apple maps only
  [0.22.0] Release (react-native-community#2535)
  Fix for “The specified child already has a parent”
  Improve installation docs (react-native-community#2541)
  fix fitToSuppliedMarkers function (react-native-community#2524)
  Performance improvements for tracksViewChanges (react-native-community#2487)
  fix spelling mistakes
  Added flag to make sure that there has an Observer of view.
  hotfix PR react-native-community#2478
  Fix a peer dependencies warning
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.