Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix app crash in Android if building found but cannot getActiveLevelIndex #2598

Merged
merged 2 commits into from Nov 23, 2018

Conversation

Projects
None yet
3 participants
@luciferes
Copy link
Contributor

luciferes commented Nov 22, 2018

Does any other open PR do the same thing?
No, it doesn't.

What issue is this PR fixing?

Fix Android app crash because building.getActiveLevelIndex() return index that out of bounds of
the building when map found a building but showsIndoors is false. Exception error message as below

Fatal Exception: java.lang.ArrayIndexOutOfBoundsException length=8; index=-1 java.util.ArrayList.get (ArrayList.java:439) com.airbnb.android.react.maps.AirMapView.onIndoorLevelActivated (AirMapView.java:1112)

How did you test this PR?

Tested on Android emulator (Nexus 5), real Android device (HTC U11), iOS Simulator (iPhone X), real iOS device (iPhone 6S) by running example.

luciferes and others added some commits Nov 22, 2018

ITONE\bussakorn.wonghom
[Android] Fix app crash in Android if building found but cannot getAc…
…tiveLevelIndex

## check building is not null
## check activeLevelIndex is in array's bound
@rborn

This comment has been minimized.

Copy link
Collaborator

rborn commented Nov 22, 2018

LGTM @alvelig @miracle2k 🐽

@miracle2k

This comment has been minimized.

Copy link
Contributor

miracle2k commented Nov 23, 2018

👍

@rborn rborn merged commit e84b35c into react-native-community:master Nov 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

ryanbourneuk pushed a commit to 3sidedcube/react-native-maps that referenced this pull request Dec 10, 2018

Ryan Bourne
Merge remote-tracking branch 'upstream/master'
* upstream/master: (28 commits)
  Calculate bounding box from region (react-native-community#2615)
  [iOS GoogleMap] Fix animateCamera (react-native-community#2608)
  Fix type definition error (react-native-community#2607)
  [Android] Fix app crash in Android if building found but cannot getActiveLevelIndex (react-native-community#2598)
  Provide a camera system (react-native-community#2563)
  Get visible map bounding box (react-native-community#2571)
  [0.22.1] Release (react-native-community#2574)
  Move dev only deps to devDependencies. (react-native-community#2548)
  Specify how to use Google Maps (react-native-community#2550)
  r2507: remove marker: Attempt to invoke virtual method 'void com.google.android.gms.maps.model.setIcon(com.google.android.gms.maps.model.BitmapDescription)' on a null object reference #: remove marker: Attempt to invoke virtual method 'void com.google.android.gms.maps.model.setIcon(com.google.android.gms.maps.model.BitmapDescription)' on a null object reference (react-native-community#2555)
  update to clarify cacheEnabled is apple maps only
  [0.22.0] Release (react-native-community#2535)
  Fix for “The specified child already has a parent”
  Improve installation docs (react-native-community#2541)
  fix fitToSuppliedMarkers function (react-native-community#2524)
  Performance improvements for tracksViewChanges (react-native-community#2487)
  fix spelling mistakes
  Added flag to make sure that there has an Observer of view.
  hotfix PR react-native-community#2478
  Fix a peer dependencies warning
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.