Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defaults to the map services version instead of play services #2653

Merged
merged 1 commit into from Jan 16, 2019

Conversation

Projects
None yet
2 participants
@vincentvella
Copy link
Contributor

vincentvella commented Jan 10, 2019

As of now the googlePlayServicesMapsVersion variable defaults to "DEFAULT_GOOGLE_PLAY_SERVICES_VERSION" which is an unpublished version of maps - 16. 0.1, it needs to default to "DEFAULT_GOOGLE_PLAY_SERVICES_MAPS_VERSION" instead which is 16.0.0

Does any other open PR do the same thing?

No, no other PR's have been submitted at the time of writing.

What issue is this PR fixing?

#2652

How did you test this PR?

Ran the sync before and after fixing with it symlinked, my PR fixes the issue with downloading the correct play services version.

Defaults to the map services version instead of play services
As of now the googlePlayServicesMapsVersion variable defaults to "DEFAULT_GOOGLE_PLAY_SERVICES_VERSION" which is an unpublished version of maps - 16. 0.1, it needs to default to "DEFAULT_GOOGLE_PLAY_SERVICES_MAPS_VERSION" instead which is 16.0.0
@rborn

This comment has been minimized.

Copy link
Collaborator

rborn commented Jan 11, 2019

@vincentvella thnx for the PR, is this working with the current git version (that's not yet published on npm)

@vincentvella

This comment has been minimized.

Copy link
Contributor Author

vincentvella commented Jan 11, 2019

Yes, confirmed this change worked from the current master with my added change. Fixed our CI process @rborn . It seems like the defaulted variable in that file was defaulting maps-version to 16.0.1 instead of 16.0.0 (16.0.1 maps doesn't exist).

@vincentvella vincentvella referenced this pull request Jan 11, 2019

Closed

Play Services Maps #2652

@rborn rborn merged commit ead2bca into react-native-community:master Jan 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.