Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Defaults to the map services version instead of play services #2653
As of now the googlePlayServicesMapsVersion variable defaults to "DEFAULT_GOOGLE_PLAY_SERVICES_VERSION" which is an unpublished version of maps - 16. 0.1, it needs to default to "DEFAULT_GOOGLE_PLAY_SERVICES_MAPS_VERSION" instead which is 16.0.0
Does any other open PR do the same thing?
No, no other PR's have been submitted at the time of writing.
What issue is this PR fixing?
How did you test this PR?
Ran the sync before and after fixing with it symlinked, my PR fixes the issue with downloading the correct play services version.
Yes, confirmed this change worked from the current master with my added change. Fixed our CI process @rborn . It seems like the defaulted variable in that file was defaulting maps-version to 16.0.1 instead of 16.0.0 (16.0.1 maps doesn't exist).