Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo #2685

Merged
merged 1 commit into from Feb 3, 2019

Conversation

Projects
None yet
3 participants
@RWOverdijk
Copy link
Contributor

RWOverdijk commented Feb 1, 2019

TLDR LOL

@markmssd

This comment has been minimized.

Copy link

markmssd commented Feb 1, 2019

Looks like a breaking change, did you test it properly? Unit tests? Functional tests? Regression tests? Performance tests?

!!!

@RWOverdijk

This comment has been minimized.

Copy link
Contributor Author

RWOverdijk commented Feb 1, 2019

@markmssd I did something better. I printed it out and did a taste test. I unomnommented it.

@christopherdro christopherdro merged commit 6b2ddbf into react-native-community:master Feb 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RWOverdijk RWOverdijk deleted the RWOverdijk:patch-1 branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.