Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable RN projects to define the Android AppCompat Library version (and fix dependency issues with RN 0.59 RC) #2702

Merged

Conversation

Projects
None yet
3 participants
@jerolimov
Copy link
Contributor

jerolimov commented Feb 20, 2019

Does any other open PR do the same thing?

No

What issue is this PR fixing?

Issue #2695, a problem with the upcoming version of react-native. This should also work with all previous versions of RN.

How did you test this PR?

  • Use a RN 0.58.x project with react-native-maps which works fine.
  • Update RN to 0.59.0-rc.2. This new version has some other gradle depencies and use Android 28 as build tool. Some other changes are also required, a complete diff is available here.
  • The build breaks with only updating RN.
  • The build works again with applying this change. (My project uses supportLibVersion = "28.0.0")

Test this PR before it got merged

You can test it with your project by installing this branch directly from GitHub:

npm install --save "react-native-maps@jerolimov/react-native-maps#fix-rn59rc-compile-issues"

or

yarn add "react-native-maps@jerolimov/react-native-maps#fix-rn59rc-compile-issues"

Remember to switch back to the official releases as soon as possible. 馃槒

@jerolimov jerolimov changed the title Enable RN projects to define the Android AppCompat Library version Enable RN projects to define the Android AppCompat Library version (and fix dependency issues with RN 0.59 RC) Feb 20, 2019

@rborn

This comment has been minimized.

Copy link
Collaborator

rborn commented Feb 20, 2019

LGTM
@alvelig 馃惤

@alvelig

This comment has been minimized.

Copy link
Collaborator

alvelig commented Feb 20, 2019

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.