Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Marker icon property introduced in #2650 to index.d.ts #2705

Merged
merged 1 commit into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@sttz
Copy link
Contributor

commented Feb 24, 2019

Does any other open PR do the same thing?

No.

What issue is this PR fixing?

With TypeScript, trying to use the Marker's icon property results in an error, since the index.d.ts does not yet declare the property that was added in #2650.

How did you test this PR?

Tested by editing the index.d.ts locally. Since there are no functional changes, this is a trivial change.

Add Marker icon property introduced in #2650 to index.d.ts
### Does any other open PR do the same thing?

No.

### What issue is this PR fixing?

With TypeScript, trying to use the Marker's icon property results in an error, since the `index.d.ts` does not yet declare the property that was added in #2650.

### How did you test this PR?

Tested by editing the `index.d.ts` locally. Since there are no functional changes, this is a trivial change.

@christopherdro christopherdro merged commit 558b34c into react-native-community:master Mar 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.