Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clearer notes to setMapBoundaries method #2707

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
2 participants
@chris-poe
Copy link
Contributor

chris-poe commented Feb 24, 2019

When using the setMapBoundaries method, it is not immediately clear why the user is able to scroll past the specified boundaries. Noting that the method uses the maps center coordinates would help clarify.

Does any other open PR do the same thing?

No, there are no other pull requests open on this issue.

What issue is this PR fixing?

Clarifies the use of the setMapBoundaries method.

How did you test this PR?

No testing needed for markdown edits.

Add clearer notes to setMapBoundaries method
When using the setMapBoundaries method, it is not immediately clear why the user is able to scroll past the specified boundaries. Noting that the method uses the maps center coordinates would help clarify.

@christopherdro christopherdro merged commit 2e0c89d into react-native-community:master Mar 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.