Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-native to 0.59.3 #2792

Merged

Conversation

Projects
None yet
2 participants
@friederbluemle
Copy link
Contributor

commented Apr 5, 2019

Does any other open PR do the same thing?

No

What issue is this PR fixing?

This updates the react-native dependency in the example project from 0.54 to the latest version 0.59.3.

How did you test this PR?

Tested on:

  • Android Emulator
  • Android Device (Xiaomi A1)
  • iOS Simultor (iPhone X)
  • iOS Device (iPhone 8)
@rborn

This comment has been minimized.

Copy link
Collaborator

commented Apr 5, 2019

@friederbluemle ❤️

Could you try to update travis config to node 10 maybe it builds 🤗

@friederbluemle friederbluemle force-pushed the friederbluemle:upgrade-react-native branch from 803d4ea to 94e3030 Apr 5, 2019

@friederbluemle

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

@rborn - Update to 8 was enough to make it pass. Please let me know if you prefer it to be set to 10 (it would be my preference too, since it's the current LTS version).

@friederbluemle

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

We could also set it to lts/*, as explained here: https://docs.travis-ci.com/user/languages/javascript-with-nodejs/

@rborn

This comment has been minimized.

Copy link
Collaborator

commented Apr 5, 2019

@friederbluemle go for it 🤗

@friederbluemle friederbluemle force-pushed the friederbluemle:upgrade-react-native branch from 94e3030 to 1783242 Apr 5, 2019

@friederbluemle

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

@rborn - lts/* works well. It installs the latest long term support version (v10.15.3) 👌

@rborn rborn merged commit 00552ea into react-native-community:master Apr 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@friederbluemle friederbluemle deleted the friederbluemle:upgrade-react-native branch Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.