Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong assigned deviceWidth #226

Merged
merged 1 commit into from Nov 26, 2018

Conversation

Projects
None yet
2 participants
@wns3645
Copy link
Contributor

commented Nov 26, 2018

When I applied deviceWidth and deviceHegith props to fix android screen dimension problem, I found that the width of the modal is something wrong.
The problem is that the deviceWidth is assigned to the wrong value! I think it works well from now on.

@mmazzarolo
Copy link
Member

left a comment

Nice catch 👍

@mmazzarolo

This comment has been minimized.

Copy link
Member

commented Nov 26, 2018

Thank you @wns3645 !

@mmazzarolo mmazzarolo merged commit 9d002d1 into react-native-community:master Nov 26, 2018

@wns3645

This comment has been minimized.

Copy link
Contributor Author

commented Nov 26, 2018

@mmazzarolo May I ask you when this version will be released?

@mmazzarolo

This comment has been minimized.

Copy link
Member

commented Nov 26, 2018

Yes! Probably tomorrow or Wednesday morning, I'm not on my personal computer now.

@wns3645

This comment has been minimized.

Copy link
Contributor Author

commented Nov 26, 2018

Okay, Thanks!!

@wns3645 wns3645 deleted the wns3645:fix-device-width branch Nov 27, 2018

@mmazzarolo

This comment has been minimized.

Copy link
Member

commented Nov 27, 2018

@wns3645 landed in v7.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.