New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.57.0 Discussion #34

Closed
grabbou opened this Issue Jul 4, 2018 · 136 comments

Comments

Projects
None yet
@grabbou
Contributor

grabbou commented Jul 4, 2018

Conversation on this thread are limited to 0.57 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.57 RC cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

@grabbou grabbou changed the title from 0.57.x discussion to 0.57.x Discussion Jul 4, 2018

@kelset kelset referenced this issue Jul 5, 2018

Closed

0.56.x Discussion #14

@kelset

This comment has been minimized.

Show comment
Hide comment
@kelset

kelset Jul 23, 2018

Collaborator

Before we reach 0.57.0 we need to be sure this is fixed/closed: facebook/react-native#20327

During RC phase should be enough to change the preset dep

  - "presets": [ "react-native" ],
  + "presets": [ "metro-react-native-babel-preset" ],

But yeah we need to ensure the transition.

Collaborator

kelset commented Jul 23, 2018

Before we reach 0.57.0 we need to be sure this is fixed/closed: facebook/react-native#20327

During RC phase should be enough to change the preset dep

  - "presets": [ "react-native" ],
  + "presets": [ "metro-react-native-babel-preset" ],

But yeah we need to ensure the transition.

@Kevat

This comment has been minimized.

Show comment
Hide comment
@Kevat

Kevat Jul 30, 2018

Will this issue be resolved by 0.57:
facebook/react-native#19953

When is 0.57 due for release? It has been frustrating not being able to use react native on Windows.

Kevat commented Jul 30, 2018

Will this issue be resolved by 0.57:
facebook/react-native#19953

When is 0.57 due for release? It has been frustrating not being able to use react native on Windows.

@jamsch

This comment has been minimized.

Show comment
Hide comment
@jamsch

jamsch Jul 31, 2018

@kelset I believe you need to set module:metro-react-native-babel-preset if the module name isn't prefixed with "babel-preset".

Also preferably this commit should be cherry picked in to the next release, it's one of the few issues that we're having to maintain a fork for.

jamsch commented Jul 31, 2018

@kelset I believe you need to set module:metro-react-native-babel-preset if the module name isn't prefixed with "babel-preset".

Also preferably this commit should be cherry picked in to the next release, it's one of the few issues that we're having to maintain a fork for.

@kelset

This comment has been minimized.

Show comment
Hide comment
@kelset

kelset Jul 31, 2018

Collaborator

Hey thanks for the feedback - we still haven't released the first rc because we had some issues testing RNTester, so we'll basically sync the 0.57 branch with master asap so you'll also get that fix (I want it too 😅).

Collaborator

kelset commented Jul 31, 2018

Hey thanks for the feedback - we still haven't released the first rc because we had some issues testing RNTester, so we'll basically sync the 0.57 branch with master asap so you'll also get that fix (I want it too 😅).

@rafaellincoln

This comment has been minimized.

Show comment
Hide comment
@rafaellincoln

rafaellincoln Aug 6, 2018

Is there any chance of this commit entering version 0.57?

rafaellincoln commented Aug 6, 2018

Is there any chance of this commit entering version 0.57?

@kelset

This comment has been minimized.

Show comment
Hide comment
@kelset

kelset Aug 6, 2018

Collaborator

@rafaellincoln we are cutting the first RC of 0.57 today (unless during our testing something weird happens) and we'll basically synch the branch with master first, so you'd be able to see that commit in it 💪

Collaborator

kelset commented Aug 6, 2018

@rafaellincoln we are cutting the first RC of 0.57 today (unless during our testing something weird happens) and we'll basically synch the branch with master first, so you'd be able to see that commit in it 💪

@fungilation

This comment has been minimized.

Show comment
Hide comment
@fungilation

fungilation Aug 8, 2018

Update on 0.57 please? I'm not seeing any RC on https://github.com/facebook/react-native/releases

fungilation commented Aug 8, 2018

Update on 0.57 please? I'm not seeing any RC on https://github.com/facebook/react-native/releases

@kelset

This comment has been minimized.

Show comment
Hide comment
@kelset

kelset Aug 8, 2018

Collaborator

While testing the branch we got stuck on this facebook/react-native#20567

so until we resolve it we won't release.

In the meantime you can find a draft of the changelog for the new version in the dedicated branch - it's a WIP but if you want to have a quick view of what is going to happen there you can read it.

Collaborator

kelset commented Aug 8, 2018

While testing the branch we got stuck on this facebook/react-native#20567

so until we resolve it we won't release.

In the meantime you can find a draft of the changelog for the new version in the dedicated branch - it's a WIP but if you want to have a quick view of what is going to happen there you can read it.

@kelset

This comment has been minimized.

Show comment
Hide comment
@kelset

kelset Aug 14, 2018

Collaborator

Quick update, we managed - with the help of a few amazing devs of this community - to finally get to a stage where we are feeling ok with releasing the first RC.

Currently CI is blocked by an invalid npm token, but it's being taken care of so expect 0.57-rc0 to be on npm in the next 12/24 hours.

Collaborator

kelset commented Aug 14, 2018

Quick update, we managed - with the help of a few amazing devs of this community - to finally get to a stage where we are feeling ok with releasing the first RC.

Currently CI is blocked by an invalid npm token, but it's being taken care of so expect 0.57-rc0 to be on npm in the next 12/24 hours.

@grabbou

This comment has been minimized.

Show comment
Hide comment
@grabbou

grabbou Aug 15, 2018

Contributor

While we are waiting for the npm token to be released, there's work already happening on getting the docs in place (thanks to @turnrye).

We are looking for a period of ~2 weeks before we promote RC to stable. That should give us enough time to make sure it works without any major regressions and get us back into the monthly release cycle.

Note: The release cycle is being currently discussed here

Contributor

grabbou commented Aug 15, 2018

While we are waiting for the npm token to be released, there's work already happening on getting the docs in place (thanks to @turnrye).

We are looking for a period of ~2 weeks before we promote RC to stable. That should give us enough time to make sure it works without any major regressions and get us back into the monthly release cycle.

Note: The release cycle is being currently discussed here

@grabbou

This comment has been minimized.

Show comment
Hide comment
@grabbou

grabbou Aug 17, 2018

Contributor

React Native 0.57.0-rc.0 is out https://www.npmjs.com/package/react-native/v/0.57.0-rc.0. The docs are going to be published in a while I believe.

Contributor

grabbou commented Aug 17, 2018

React Native 0.57.0-rc.0 is out https://www.npmjs.com/package/react-native/v/0.57.0-rc.0. The docs are going to be published in a while I believe.

@fungilation

This comment has been minimized.

Show comment
Hide comment
@fungilation

fungilation Aug 17, 2018

Can't go further than react-native-git-upgrade 0.57.0-rc.0 since that's breaking for me.

Good old react-native upgrade is also broken.

facebook/react-native#20710

fungilation commented Aug 17, 2018

Can't go further than react-native-git-upgrade 0.57.0-rc.0 since that's breaking for me.

Good old react-native upgrade is also broken.

facebook/react-native#20710

@kelset

This comment has been minimized.

Show comment
Hide comment
@kelset

kelset Aug 17, 2018

Collaborator

A few issues and PRs we should try to have merged (and cherry picked) for 0.57.0:

Collaborator

kelset commented Aug 17, 2018

A few issues and PRs we should try to have merged (and cherry picked) for 0.57.0:

@danielgindi

This comment has been minimized.

Show comment
Hide comment
@danielgindi

danielgindi Aug 17, 2018

Is react-native published to nexus?
Because there are issues with many native libraries, with dependencies like compile 'com.facebook.react:react-native:+' - where Android Studio tries to download 0.20.1 and compile against that.

Update:
Many native modules reference maven { url "$projectDir/../node_modules/react-native/android" }, but react-native/android does not exist.

danielgindi commented Aug 17, 2018

Is react-native published to nexus?
Because there are issues with many native libraries, with dependencies like compile 'com.facebook.react:react-native:+' - where Android Studio tries to download 0.20.1 and compile against that.

Update:
Many native modules reference maven { url "$projectDir/../node_modules/react-native/android" }, but react-native/android does not exist.

@rozele

This comment has been minimized.

Show comment
Hide comment
@rozele

rozele Aug 17, 2018

Once it's merged, can we cherry-pick facebook/react-native#20705 onto 0.57-stable and cut another RC for react-native-windows and react-native-dom. +@vincentriemer

rozele commented Aug 17, 2018

Once it's merged, can we cherry-pick facebook/react-native#20705 onto 0.57-stable and cut another RC for react-native-windows and react-native-dom. +@vincentriemer

@janhesters

This comment has been minimized.

Show comment
Hide comment
@janhesters

janhesters Aug 20, 2018

Will this issue #19859 (testing) be fixed in version 0.57? It feels weird for a lot of new people that testing is broken out of the box.

janhesters commented Aug 20, 2018

Will this issue #19859 (testing) be fixed in version 0.57? It feels weird for a lot of new people that testing is broken out of the box.

@grabbou

This comment has been minimized.

Show comment
Hide comment
@grabbou

grabbou Aug 20, 2018

Contributor

Yes, @janhesters, this should be fixed. I already commented on that issue. Thanks for rising that - this is exactly what this issue is for.

@danielgindi, please raise your issue in RN repository itself. The RN comes always from node_modules and we never publish the Android version to any external dependency center (including Maven etc.). I believe there might be some historical versions published there, which gives you an error about the wrong version. Try installing node modules again.

@fungilation there's ongoing discussion about whether to rewrite/drop react-native-git-upgrade entirely due to its brittleness with new upgrades. Are you able to provide your feedback about it, preferably via email? (it's on my profile) We could start a proposal to create a better, new, version of it. If you feel like having enough free time, I could help you get it up and running.

Contributor

grabbou commented Aug 20, 2018

Yes, @janhesters, this should be fixed. I already commented on that issue. Thanks for rising that - this is exactly what this issue is for.

@danielgindi, please raise your issue in RN repository itself. The RN comes always from node_modules and we never publish the Android version to any external dependency center (including Maven etc.). I believe there might be some historical versions published there, which gives you an error about the wrong version. Try installing node modules again.

@fungilation there's ongoing discussion about whether to rewrite/drop react-native-git-upgrade entirely due to its brittleness with new upgrades. Are you able to provide your feedback about it, preferably via email? (it's on my profile) We could start a proposal to create a better, new, version of it. If you feel like having enough free time, I could help you get it up and running.

@janhesters

This comment has been minimized.

Show comment
Hide comment
@janhesters

janhesters Aug 20, 2018

@grabbou Awesome news! Thank you very much.

janhesters commented Aug 20, 2018

@grabbou Awesome news! Thank you very much.

@kelset

This comment has been minimized.

Show comment
Hide comment
@kelset

kelset Aug 20, 2018

Collaborator

Update on my previous comment:

To answer @janhesters - if you've read my comment at the bottom in that issue, it explains how it's not a react-native issue per se. That said we may consider "removing" jest from the init template so that we can avoid this:

It feels weird for a lot of new people that testing is broken out of the box.

Collaborator

kelset commented Aug 20, 2018

Update on my previous comment:

To answer @janhesters - if you've read my comment at the bottom in that issue, it explains how it's not a react-native issue per se. That said we may consider "removing" jest from the init template so that we can avoid this:

It feels weird for a lot of new people that testing is broken out of the box.

@rozele

This comment has been minimized.

Show comment
Hide comment
@rozele

rozele Aug 20, 2018

@kelset - I commented on facebook/react-native#20706. That comment does not depend on the change to metro. Metro still accepts the option for --reset-cache, the change to metro only affects the internal handling of that flag and ensures it's passed down to jest-haste-map

Edit: Also - facebook/react-native@c5297c7 is not blocked on metro either, so that can be cherry-picked ASAP so we can release an RC for react-native-windows targeting 0.57 RC.1.

rozele commented Aug 20, 2018

@kelset - I commented on facebook/react-native#20706. That comment does not depend on the change to metro. Metro still accepts the option for --reset-cache, the change to metro only affects the internal handling of that flag and ensures it's passed down to jest-haste-map

Edit: Also - facebook/react-native@c5297c7 is not blocked on metro either, so that can be cherry-picked ASAP so we can release an RC for react-native-windows targeting 0.57 RC.1.

@fungilation

This comment has been minimized.

Show comment
Hide comment
@fungilation

fungilation Aug 20, 2018

@grabbou I'm emailing you. But I'll say here that react-native-git-upgrade has been reliably upgrading every version for me since about 0.50 or earlier. And no doubt it's better than react-native upgrade with its 3 way merging of template files, instead of manual diffing. I'm all for a better version of react-native-git-upgrade.

fungilation commented Aug 20, 2018

@grabbou I'm emailing you. But I'll say here that react-native-git-upgrade has been reliably upgrading every version for me since about 0.50 or earlier. And no doubt it's better than react-native upgrade with its 3 way merging of template files, instead of manual diffing. I'm all for a better version of react-native-git-upgrade.

@janhesters

This comment has been minimized.

Show comment
Hide comment
@janhesters

janhesters Aug 20, 2018

@kelset Yup I've read your comment and it helped me tremendously! It's a well working fix, thank you very much for that.

Why not just add that fix to the stable version of React Native? In my opinion removing jest from react-native init template would be a bad move, because having Jest shipped with React Native encourages great programming!
I always loved for example how Django also ships with testing files and has a explicit chapter about testing in it's docs.
When I first picked up React Native I was excited to see that other frameworks also animate the user to write tests. It's an amazing privilege for new programmers, when they get lead by more experienced programmers to use best practices and write long-term stable code 🔥🤓

janhesters commented Aug 20, 2018

@kelset Yup I've read your comment and it helped me tremendously! It's a well working fix, thank you very much for that.

Why not just add that fix to the stable version of React Native? In my opinion removing jest from react-native init template would be a bad move, because having Jest shipped with React Native encourages great programming!
I always loved for example how Django also ships with testing files and has a explicit chapter about testing in it's docs.
When I first picked up React Native I was excited to see that other frameworks also animate the user to write tests. It's an amazing privilege for new programmers, when they get lead by more experienced programmers to use best practices and write long-term stable code 🔥🤓

@kelset

This comment was marked as resolved.

Show comment
Hide comment
@kelset

kelset Sep 12, 2018

Collaborator

releasing a new version of react-native-git-upgrade

I think that it would be great to have someone to maintain it "properly", at the moment is not being actively maintained AFAIK. Last time we spoke about it was during a core meeting.

That said, I think that it'd be better to open a dedicated issue to discuss its future here so that we can keep this issue on-topic.

Collaborator

kelset commented Sep 12, 2018

releasing a new version of react-native-git-upgrade

I think that it would be great to have someone to maintain it "properly", at the moment is not being actively maintained AFAIK. Last time we spoke about it was during a core meeting.

That said, I think that it'd be better to open a dedicated issue to discuss its future here so that we can keep this issue on-topic.

@fungilation

This comment was marked as off-topic.

Show comment
Hide comment
@fungilation

fungilation Sep 12, 2018

react-native-git-upgrade should get a version bump on npm right now before discussion on its maintainability, as it's broken right now for anyone using it to upgrade to 0.57.

fungilation commented Sep 12, 2018

react-native-git-upgrade should get a version bump on npm right now before discussion on its maintainability, as it's broken right now for anyone using it to upgrade to 0.57.

@markharding

This comment was marked as off-topic.

Show comment
Hide comment
@markharding

markharding Sep 13, 2018

Can the following patch be applied for 0.57.1 facebook/react-native#20798?

markharding commented Sep 13, 2018

Can the following patch be applied for 0.57.1 facebook/react-native#20798?

@jamsch

This comment has been minimized.

Show comment
Hide comment
@jamsch

jamsch Sep 13, 2018

Just noticed that ReactFragmentActivity says it will be removed on the 0.57 release. Will this still be removed?

jamsch commented Sep 13, 2018

Just noticed that ReactFragmentActivity says it will be removed on the 0.57 release. Will this still be removed?

@empyrical

This comment has been minimized.

Show comment
Hide comment
@empyrical

empyrical Sep 13, 2018

Member

I would love if this commit made it into 0.57.1:

facebook/react-native@4b106be

Member

empyrical commented Sep 13, 2018

I would love if this commit made it into 0.57.1:

facebook/react-native@4b106be

@hramos

This comment has been minimized.

Show comment
Hide comment
@hramos

hramos Sep 13, 2018

Collaborator

@jamsch it didn't end up getting removed. We should probably remove that comment, as we have not formalized how deprecations should be handled (as in, how many releases will we allow them to remain @deprecated before outright removing them).

Collaborator

hramos commented Sep 13, 2018

@jamsch it didn't end up getting removed. We should probably remove that comment, as we have not formalized how deprecations should be handled (as in, how many releases will we allow them to remain @deprecated before outright removing them).

@hramos

This comment has been minimized.

Show comment
Hide comment
@hramos

hramos Sep 13, 2018

Collaborator

@markharding we're only cherry-picking commits from master. That PR is still open.

Collaborator

hramos commented Sep 13, 2018

@markharding we're only cherry-picking commits from master. That PR is still open.

@kelset

This comment has been minimized.

Show comment
Hide comment
@kelset

kelset Sep 18, 2018

Collaborator

As a rough estimate for 0.57.1, currently we are focusing on having XCode 10 working properly with RN (since they just released it, it will take a few days at least still) plus a Metro fix before releasing it.

Aside from that, please only ask for commits already merged to master - as probably we will only cut a first 0.58 rc after we release 0.57.1.

Collaborator

kelset commented Sep 18, 2018

As a rough estimate for 0.57.1, currently we are focusing on having XCode 10 working properly with RN (since they just released it, it will take a few days at least still) plus a Metro fix before releasing it.

Aside from that, please only ask for commits already merged to master - as probably we will only cut a first 0.58 rc after we release 0.57.1.

@rafeca

This comment has been minimized.

Show comment
Hide comment
@rafeca

rafeca Sep 18, 2018

The fix for Metro already landed in master (the change is only in the React Native repo).
This is the commit: facebook/react-native@7a69f1a and it would be lovely if it's cherry-picked to v0.57.1

rafeca commented Sep 18, 2018

The fix for Metro already landed in master (the change is only in the React Native repo).
This is the commit: facebook/react-native@7a69f1a and it would be lovely if it's cherry-picked to v0.57.1

@hramos

This comment has been minimized.

Show comment
Hide comment
@hramos

hramos Sep 18, 2018

Collaborator

Xcode fix: I nominate facebook/react-native@8103c43 for 0.57.1. That commit is in master, but did not make the cut for 0.57.0.

Collaborator

hramos commented Sep 18, 2018

Xcode fix: I nominate facebook/react-native@8103c43 for 0.57.1. That commit is in master, but did not make the cut for 0.57.0.

@hawkrives

This comment has been minimized.

Show comment
Hide comment
@hawkrives

hawkrives Sep 18, 2018

I'd like to nominate facebook/react-native@b9c28c2 for 0.57.1; without it, I have to // $FlowExpectedError whenever I use <TextInput scrollEnabled={false} />. (I think it's all ready to go; apologies if it's not.)

hawkrives commented Sep 18, 2018

I'd like to nominate facebook/react-native@b9c28c2 for 0.57.1; without it, I have to // $FlowExpectedError whenever I use <TextInput scrollEnabled={false} />. (I think it's all ready to go; apologies if it's not.)

@oblador

This comment has been minimized.

Show comment
Hide comment
@oblador

oblador Sep 19, 2018

Member

I’d like to nominate facebook/react-native@9fca769 to fix storybook compatibility.

Member

oblador commented Sep 19, 2018

I’d like to nominate facebook/react-native@9fca769 to fix storybook compatibility.

@grabbou

This comment was marked as resolved.

Show comment
Hide comment
@grabbou

grabbou Sep 20, 2018

Contributor

Currently react-native init is broken - this issue should be fixed ASAP in next release.

Contributor

grabbou commented Sep 20, 2018

Currently react-native init is broken - this issue should be fixed ASAP in next release.

@christianbach

This comment has been minimized.

Show comment
Hide comment
@christianbach

christianbach Sep 21, 2018

Perhaps facebook/react-native@d1ff0b0 is suited for the 0.57.1 release?

christianbach commented Sep 21, 2018

Perhaps facebook/react-native@d1ff0b0 is suited for the 0.57.1 release?

@kelset

This comment has been minimized.

Show comment
Hide comment
@kelset

kelset Sep 21, 2018

Collaborator

Hey everyone, the current idea is to do a small 0.57.1 before the weekend that won't fix all the Xcode 10 issues but at least give us all those nominated commits plus a couple more fixes - we just run in a Metro issue yesterday evening so we are waiting for a new release of that before proceeding.

Collaborator

kelset commented Sep 21, 2018

Hey everyone, the current idea is to do a small 0.57.1 before the weekend that won't fix all the Xcode 10 issues but at least give us all those nominated commits plus a couple more fixes - we just run in a Metro issue yesterday evening so we are waiting for a new release of that before proceeding.

@kelset

This comment has been minimized.

Show comment
Hide comment
@kelset

kelset Sep 21, 2018

Collaborator

Update: since Metro 0.45.6 has been released and works great, I've tested locally this set of cherry picks (in order of picking):

Plus, on top, the commit to "enforce" the newer metro Bump metro@0.45.6 (which caused a conflict, I think because I haven't cherry picked the other 3/4 commits that bump the minor version - I just solved it locally).

With this "local set" of commits on top of 0.57-stable all my tests were

I'm just waiting for the approval from other maintainers then we can proceed to release 0.57.1.


Minor notes on a couple more commits:

Collaborator

kelset commented Sep 21, 2018

Update: since Metro 0.45.6 has been released and works great, I've tested locally this set of cherry picks (in order of picking):

Plus, on top, the commit to "enforce" the newer metro Bump metro@0.45.6 (which caused a conflict, I think because I haven't cherry picked the other 3/4 commits that bump the minor version - I just solved it locally).

With this "local set" of commits on top of 0.57-stable all my tests were

I'm just waiting for the approval from other maintainers then we can proceed to release 0.57.1.


Minor notes on a couple more commits:

@chrisnojima

This comment was marked as resolved.

Show comment
Hide comment
@chrisnojima

chrisnojima Sep 24, 2018

Would it be possible to re-attempt to get facebook/react-native@2307ea6 in? it's a tiny diff in one file

chrisnojima commented Sep 24, 2018

Would it be possible to re-attempt to get facebook/react-native@2307ea6 in? it's a tiny diff in one file

@rowinbot

This comment was marked as resolved.

Show comment
Hide comment
@rowinbot

rowinbot Sep 24, 2018

Isn't facebook/react-native@2307ea6 packed in 0.57.0?

I've been using it for a week now and it seems to work already

rowinbot commented Sep 24, 2018

Isn't facebook/react-native@2307ea6 packed in 0.57.0?

I've been using it for a week now and it seems to work already

@hramos

This comment was marked as resolved.

Show comment
Hide comment
@hramos

hramos Sep 24, 2018

Collaborator

Yes, facebook/react-native@2307ea6 is already in 0.57, even though the tags on that commit do not show it: https://github.com/facebook/react-native/commits/0.57-stable

Collaborator

hramos commented Sep 24, 2018

Yes, facebook/react-native@2307ea6 is already in 0.57, even though the tags on that commit do not show it: https://github.com/facebook/react-native/commits/0.57-stable

@mjmasn

This comment has been minimized.

Show comment
Hide comment
@mjmasn

mjmasn Sep 24, 2018

If there's going to be a 0.57.2 it would be awesome to get these two fixes for scroll views in:
facebook/react-native@e0170a9
facebook/react-native@4af4da9

mjmasn commented Sep 24, 2018

If there's going to be a 0.57.2 it would be awesome to get these two fixes for scroll views in:
facebook/react-native@e0170a9
facebook/react-native@4af4da9

@DaveCole

This comment was marked as off-topic.

Show comment
Hide comment
@DaveCole

DaveCole Sep 24, 2018

Hey there - I followed the instructions on the changelog to update everything to 0.57.1 and am now getting the "No bundle URL present." even though react-native run-ios succeeds in building. Xcode shows main.jsbundle as missing. I'm guessing it has something to do with the babel change but I'm a little lost on what to do next. Any help would be great, thanks.

DaveCole commented Sep 24, 2018

Hey there - I followed the instructions on the changelog to update everything to 0.57.1 and am now getting the "No bundle URL present." even though react-native run-ios succeeds in building. Xcode shows main.jsbundle as missing. I'm guessing it has something to do with the babel change but I'm a little lost on what to do next. Any help would be great, thanks.

@jhaenchen

This comment was marked as off-topic.

Show comment
Hide comment
@jhaenchen

jhaenchen Sep 25, 2018

I was told by a peer that this version of react-native breaks symlinks. Is that accurate? My symlinks are definitely not working...

jhaenchen commented Sep 25, 2018

I was told by a peer that this version of react-native breaks symlinks. Is that accurate? My symlinks are definitely not working...

@kelset

This comment was marked as resolved.

Show comment
Hide comment
@kelset

kelset Sep 25, 2018

Collaborator

@jhaenchen open a dedicated issue in the main repo.

Collaborator

kelset commented Sep 25, 2018

@jhaenchen open a dedicated issue in the main repo.

@sunnylqm

This comment has been minimized.

Show comment
Hide comment
@sunnylqm

sunnylqm Sep 26, 2018

Please include this fix in 0.57.2 facebook/react-native@1323acd

sunnylqm commented Sep 26, 2018

Please include this fix in 0.57.2 facebook/react-native@1323acd

@kelset kelset changed the title from 0.57.x Discussion to 0.57.0 Discussion Sep 28, 2018

@kelset

This comment has been minimized.

Show comment
Hide comment
@kelset

kelset Sep 28, 2018

Collaborator

Hey folks, since with the core we agreed that 0.57.x is a fairly stable release and that we are waiting on a few things from FB internal codebase to land to the OSS for 0.58, we decided to "extend" the lifespan of 0.57.

For this reason, I've opened a new issue for version 0.57.1 (latest currently) to which suggest cherry picks. And similarly when 0.57.2 will be released we'll do the same.

Collaborator

kelset commented Sep 28, 2018

Hey folks, since with the core we agreed that 0.57.x is a fairly stable release and that we are waiting on a few things from FB internal codebase to land to the OSS for 0.58, we decided to "extend" the lifespan of 0.57.

For this reason, I've opened a new issue for version 0.57.1 (latest currently) to which suggest cherry picks. And similarly when 0.57.2 will be released we'll do the same.

@kelset kelset closed this Sep 28, 2018

@kelset kelset referenced this issue Sep 28, 2018

Closed

0.57.1 Discussion #45

@buixuanthe2212

This comment was marked as off-topic.

Show comment
Hide comment
@buixuanthe2212

buixuanthe2212 Oct 2, 2018

borderTopColor, borderLeftColor, borderRightColor, borderBottomColor
not working for react-native 0.57
;(

buixuanthe2212 commented Oct 2, 2018

borderTopColor, borderLeftColor, borderRightColor, borderBottomColor
not working for react-native 0.57
;(

@react-native-community react-native-community locked as resolved and limited conversation to collaborators Oct 2, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.