New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.57.5 Discussion #64

Closed
kelset opened this Issue Nov 13, 2018 · 15 comments

Comments

Projects
None yet
9 participants
@kelset
Collaborator

kelset commented Nov 13, 2018

Conversation on this thread are limited to 0.57.5 release's major issues and backport (cherry-pick) requests from commits that are already on master - so that we can then produce a 0.57.6 release in the near future.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.57.5 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.57-stable branch yourself, in order to ensure that the process proceeds smoothly.

@dulmandakh

This comment has been minimized.

Contributor

dulmandakh commented Nov 14, 2018

@ChrisEdson

This comment has been minimized.

ChrisEdson commented Nov 15, 2018

@dulmandakh

This comment has been minimized.

Contributor

dulmandakh commented Nov 16, 2018

@flybayer

This comment has been minimized.

flybayer commented Nov 16, 2018

@matpaul

This comment has been minimized.

matpaul commented Nov 17, 2018

@kelset

This comment has been minimized.

Collaborator

kelset commented Nov 22, 2018

Thanks everyone for the suggestions, I'm starting to consider creating the next release.

Aside from those, I'll probably reverse facebook/react-native@ce09d6e given that it causes crashes in production.

@radeno

This comment has been minimized.

radeno commented Nov 23, 2018

My two cents:

@kelset about crashing of <Image> component we don't have any issues. But we we use only for local images, for remote <FastImage>
What about Jest/Flow/Metro, there are still issues what was discussed in previous version topic?

@terrysahaidak

This comment has been minimized.

terrysahaidak commented Nov 26, 2018

Hi @kelset, inverted flat list fix on android 9 should be landed in this release because it's really critical, I think. it breaks every app that has a chat ability. but new 58 release because of fabric and etc may contain some new bugs (it's ok).

@watadarkstar

This comment has been minimized.

watadarkstar commented Nov 26, 2018

Not sure if we can still cherry pick at this point but I'd really like as mentioned by @terrysahaidak but with a link to the commit:

@radeno

This comment has been minimized.

radeno commented Nov 26, 2018

@watadarkstar already requested #64 (comment) make thumb up :)

@watadarkstar

This comment has been minimized.

watadarkstar commented Nov 26, 2018

Done 👍 didn't see that @radeno

@elucaswork

This comment has been minimized.

elucaswork commented Nov 26, 2018

  • Fix inability to remove 'Disabled' state from AccessibilityStates facebook/react-native@5eaa2d2. (it went straight to 0.58.0-rc.0, but would be important to also have it on 0.57)
@kelset

This comment has been minimized.

Collaborator

kelset commented Nov 26, 2018

Thanks everyone for the requests, I'll try now to apply them and we'll see how it goes...

@kelset

This comment has been minimized.

Collaborator

kelset commented Nov 26, 2018

@kelset

This comment has been minimized.

Collaborator

kelset commented Nov 26, 2018

0.57.6 is out, all my tests are so I'll proceed with closing this and opening the new one. Changelog will land soon.

@kelset kelset closed this Nov 26, 2018

@react-native-community react-native-community locked as resolved and limited conversation to collaborators Nov 26, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.