New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.57.7 Discussion #71

Closed
kelset opened this Issue Nov 27, 2018 · 11 comments

Comments

Projects
None yet
7 participants
@kelset
Copy link
Collaborator

kelset commented Nov 27, 2018

Conversation on this thread are limited to 0.57.7 release's major issues and backport (cherry-pick) requests from commits that are already on master - so that we can then produce a 0.57.8 release in the near future.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.57.7 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.57-stable branch yourself, in order to ensure that the process proceeds smoothly.

@miblanchard

This comment has been minimized.

Copy link

miblanchard commented Nov 27, 2018

Could 53da585 be cherry-picked?

@ahce

This comment has been minimized.

Copy link

ahce commented Dec 4, 2018

React sync

@radeno

This comment has been minimized.

Copy link

radeno commented Dec 5, 2018

Some other possible fixing cherry-picks

Maybe:

@dvicory

This comment has been minimized.

Copy link

dvicory commented Dec 5, 2018

👍 on facebook/react-native@8d68a3e. That metro upgrade contains the Yarn PnP resolver that I really want to make use of. 😄

@radeno

This comment has been minimized.

Copy link

radeno commented Dec 7, 2018

Another fixes:

Maybe:

@kelset

This comment has been minimized.

Copy link
Collaborator

kelset commented Dec 10, 2018

hey everyone, thanks for the suggestions, I am thinking of releasing 0.57.8 by end of the week as last release for 0.57 for this year.

I'll keep you updated.


EDIT: I won't upgrade Metro because it relies on an alpha of Jest. You are free to enforce it in your local project, but for this branch we are trying to keep things as stable as possible.

@levibuzolic

This comment has been minimized.

Copy link

levibuzolic commented Dec 10, 2018

Any chance we could get facebook/react-native@077386a into 0.57.8? Or would it be more appropriate for the 0.58.0 release?

Oops never mind, got reverted. Will wait to find out what happened and get it back in. 🤦‍♂️

@radeno

This comment has been minimized.

Copy link

radeno commented Dec 11, 2018

@levibuzolic that commit was reverted. So i don't think so.

@sunnylqm

This comment has been minimized.

Copy link

sunnylqm commented Dec 12, 2018

@kelset

This comment has been minimized.

Copy link
Collaborator

kelset commented Dec 12, 2018

Hey everyone, just cherry-picked the commits, tested locally all everything went smoothly - now pushed to repo to test CI. You can see the list of commits here.

Didn't cherry pick because created conflicts:

@kelset

This comment has been minimized.

Copy link
Collaborator

kelset commented Dec 13, 2018

Release 0.57.8 is now on npm, I'll publish the changelog in a bit.

Thanks to everyone who got involved, you can follow up the conversation for 0.57.8 in its dedicated issue.

@kelset kelset closed this Dec 13, 2018

@react-native-community react-native-community locked as resolved and limited conversation to collaborators Dec 13, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.