Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Unable to set transparent background #475

Closed
maxschmeling opened this issue Apr 3, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@maxschmeling
Copy link
Contributor

commented Apr 3, 2019

After upgrading to 5.6.1 from 5.4.1 I'm no longer able to set a transparent background on a WebView.

I think it broke in 319a86e

The background is always white.

@maxschmeling

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

I have confirmed that the commit I referenced is the cause and the specific line is 319a86e#diff-a32cd1cea4d19bbfff56369224e62299R18 where the webview's container style has backgroundColor set to white.

@Ehesp

This comment has been minimized.

Copy link
Collaborator

commented Apr 3, 2019

Thanks for the report. Please could you send in a PR to remove this. @Titozzz do you know the reason for making the style change?

@maxschmeling

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

I hadn't sent a PR yet because I wasn't sure of the reason for the change. I'm not sure if it's needed for something on Android.

If it's safe to remove, I'll submit a PR to remove the backgroundColor style.

@Titozzz Titozzz closed this in #478 Apr 4, 2019

Titozzz added a commit that referenced this issue Apr 4, 2019

fix(styles): Removes hard-coded container white backgroundColor (#478)
Fixes #475

#472 added a `backgroundColor` of `white` to the `container` style which broke the ability to set a `transparent` background color on the `WebView` component. This simply removes that unnecessary style.

react-native-community-bot pushed a commit that referenced this issue Apr 4, 2019

chore(release): 5.6.2 [skip ci]
## [5.6.2](v5.6.1...v5.6.2) (2019-04-04)

### Bug Fixes

* **styles:** Removes hard-coded container white backgroundColor ([#478](#478)) ([5ec74ea](5ec74ea)), closes [#475](#475) [#472](#472)
@react-native-community-bot

This comment has been minimized.

Copy link
Collaborator

commented Apr 4, 2019

🎉 This issue has been resolved in version 5.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.