Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[feat] Add `cacheEnabled` prop #152
This PR 'fixes' #128
For my project I can confirm that this PR improves the caching and performance. Thanks for this PR. I think this is a great and important improvement.
Without this _enableCache is always false in
I would also recommend to rename
@Titozzz Sorry for the delay. Thanks for applying the feedback. Sourcecode looks fine. I tested it also in a live project on iOS and it works as expected.
(I could not verify this on Android yet, because I have other troubles with my Android build atm.)
Imported the Webivew as required and than :
Rest are working fine but 'cacheEnable' could be verified once I have live build Soon. Let me know if anything need to change.
@munsifhayat With your linked version, you referes to the latest react-native-webview. This version does not include the cacheEnabled prop until this PR got merged.
You need to refer the branch which is requested to merge here. You can define this in your package.json this way:
I install this with yarn (npm install should work similar):
You find the username and branch of the PR in the top-right corner of the PR:
Hope this helps.