Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.62.2 Discussion #188

Closed
alloy opened this issue Apr 8, 2020 · 31 comments
Closed

v0.62.2 Discussion #188

alloy opened this issue Apr 8, 2020 · 31 comments

Comments

@alloy
Copy link
Member

@alloy alloy commented Apr 8, 2020

Conversations on this thread should be limited to reporting issues that are new in this minor version or requests to cherry-pick bug fixes that have landed in master.

In all other cases, please report the issue to http://github.com/facebook/react-native/issues.

@Maskedman99

This comment has been hidden.

@SaeedZhiany
Copy link

@SaeedZhiany SaeedZhiany commented Apr 9, 2020

Can we cherry-pick this?
facebook/react-native@7980615

@alloy

This comment has been hidden.

@sunnylqm
Copy link
Contributor

@sunnylqm sunnylqm commented Apr 10, 2020

@guhungry
Copy link

@guhungry guhungry commented Apr 12, 2020

Fix app crash due to flipper 0.33.1 in ios debug build when use base64 image facebook/react-native@17f025b

@SaeedZhiany

This comment has been hidden.

@sunnylqm

This comment has been hidden.

@SaeedZhiany

This comment has been hidden.

@sunnylqm

This comment has been hidden.

@christianbach
Copy link

@christianbach christianbach commented Apr 14, 2020

@naved971

This comment was marked as off-topic.

@mikehardy

This comment was marked as off-topic.

@Bardiamist

This comment was marked as off-topic.

@ahce
Copy link

@ahce ahce commented Apr 21, 2020

@Knjaz89

This comment was marked as off-topic.

@levibuzolic

This comment was marked as off-topic.

@Knjaz89

This comment was marked as off-topic.

@Bardiamist

This comment was marked as off-topic.

@zhongwuzw
Copy link

@zhongwuzw zhongwuzw commented May 5, 2020

Could we pick this facebook/react-native@9cdc19a?

@AnOptimistSeePessimist

This comment was marked as off-topic.

@mikehardy

This comment was marked as off-topic.

@chris-griffin
Copy link

@chris-griffin chris-griffin commented May 28, 2020

Can we pick facebook/react-native@a2f8b9c which fixes an incorrect white text color being applied on TextInputs when an iOS device is set to dark mode even if the background of the input is white as well?

@njiyto
Copy link

@njiyto njiyto commented May 31, 2020

Important info if you use Hermes
I updated from 61.5 to 62.2 and got a crash on android:
couldn't find DSO to load: libhermes-executor-debug.so

I fixed it by adding following string to android/app/build.gradle:
implementation "org.webkit:android-jsc:+"

@JLucasCAmorim
Copy link

@JLucasCAmorim JLucasCAmorim commented Jun 2, 2020

Can we pick facebook/react-native@e5a6655 which fixes the Animated image crash when CADisplayLink target in RCTWeakProxy is nil?

@jakobvase
Copy link

@jakobvase jakobvase commented Jun 5, 2020

Can we pick facebook/react-native@33b3a1a? Changes the launch screen from .xib to .storyboard, as required by Apple before June 30th (https://developer.apple.com/news/?id=03262020b).

@SaeedZhiany
Copy link

@SaeedZhiany SaeedZhiany commented Jun 29, 2020

@alloy
Are all the requested cherry-picks in this issue included in 0.63.x? If yes, we can close this issue right? otherwise, I'm wondering which version will include those cherry picks?

Thanks.

@chris-griffin
Copy link

@chris-griffin chris-griffin commented Jun 29, 2020

I would definitely love to see these cherry-picks added to a new 62.2.3 release. This seems necessary especially given #188 (comment) (which will break things starting tomorrow). But in general, we would be very grateful to see additional stability in releases by backporting fixes to the previous major/minor patch.

@radko93
Copy link

@radko93 radko93 commented Jun 29, 2020

@chris-griffin this only affects new projects, if you have an existing project you need to migrate to a storyboard manually anyway. But it has to be included in 0.63.

@kelset
Copy link
Member

@kelset kelset commented Jun 30, 2020

echoing what @radko93 just said, cherry picking the commit won't autofix/autoupdate any already existing app. That change needs to be done manually anyway, so in all fairness since we are releasing 0.63.0 very soon I don't think it's necessary to release 0.62.3 (since it won't come out before 0.63 anyway and react-native init will use 0.63).

@sunnylqm
Copy link
Contributor

@sunnylqm sunnylqm commented Jul 4, 2020

@alloy
Copy link
Member Author

@alloy alloy commented Jul 6, 2020

Thanks for bearing with us and reporting issues/requests for picks 🙏 Due to available bandwidth, we decided to focus on getting a v0.63.0 release out rather than another v0.62.x patch release. I’ve gone through all the requested picks and have added those that are not yet slated for v0.63.0 to be picked for v0.63.1: #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet