Skip to content
This repository has been archived by the owner. It is now read-only.

Upcoming v0.64.2 cherrypicks discussion #224

Closed
3 of 14 tasks
kelset opened this issue May 5, 2021 · 47 comments
Closed
3 of 14 tasks

Upcoming v0.64.2 cherrypicks discussion #224

kelset opened this issue May 5, 2021 · 47 comments

Comments

@kelset
Copy link
Member

@kelset kelset commented May 5, 2021

Conversations on this thread are limited to 0.64 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.64.1 cut, with a link to the specific commit hash on master with the commit to cherry-pick, like this example link: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

PRs to merge:

Ready for cherry-pick:

Issues to resolve:

@myckhel
Copy link

@myckhel myckhel commented May 5, 2021

i feel the previous discussion #221 has less meaning.
after all only 5 commits were pushed to the v0.64.1 stack.

@kelset
Copy link
Member Author

@kelset kelset commented May 5, 2021

@myckhel the reason why 0.64.1 was so small is that we wanted to quickly address the Xcode 12.5 problem which was a real blocker for a lot of developers.

@mikehardy
Copy link

@mikehardy mikehardy commented May 7, 2021

Issue facebook/react-native#31245 just got a resolution!
Please please cherry pick facebook/react-native@b0e8c1e and thank you :-)

@danilobuerger
Copy link

@danilobuerger danilobuerger commented May 7, 2021

@kelset the issue that @mikehardy mentioned seems to be a pretty big blocker too judging by the amount of emojis the issue got in that short time frame. Maybe its worth doing a speedy release here too?

@haralddoderer
Copy link

@haralddoderer haralddoderer commented May 9, 2021

@kelset the issue that @mikehardy mentioned seems to be a pretty big blocker too judging by the amount of emojis the issue got in that short time frame. Maybe its worth doing a speedy release here too?

It would be nice if there was some kind of patch or a workaround available until we get the next release. I also still use 0.64.1 and I am afraid that lot's of dependencies then might break on updating. A backport to 0.64.1 would also be welcomed.

@kelset I just want to say thank you for all the hard work you invest. Hope you can help us here.

@sanduluca
Copy link

@sanduluca sanduluca commented May 13, 2021

Please cherry pick facebook/react-native@00d9dea
This is very annoying to see that your styles are not working properly.
Thank you for your work. 🔥

@riccardonucleare
Copy link

@riccardonucleare riccardonucleare commented May 14, 2021

Please cherry pick: facebook/react-native#31457
Quite an important issue to add.

@mikehardy
Copy link

@mikehardy mikehardy commented May 14, 2021

@riccardonucleare that issue is not closed, there is no commit landed on master, it is not a valid cherry-pick request. From the top of this issue

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.64.1 cut, with a link to the specific commit hash on master with the commit to cherry-pick, like this example link: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

I think best course is to focus effort on getting it merged then it's time to head here and request a pick

@shrmaky

This comment was marked as off-topic.

@beetlebum

This comment was marked as off-topic.

@AstroCorp
Copy link

@AstroCorp AstroCorp commented May 17, 2021

merge this fix please :/

facebook/react-native#29099

@mikehardy
Copy link

@mikehardy mikehardy commented May 17, 2021

@AstroCorp this is for cherry-picks, which implies there is a commit to cherrypick. That is a PR, it is not merged, there is no commit.

@fabriziobertoglio1987

This comment has been minimized.

@capJavert
Copy link

@capJavert capJavert commented May 17, 2021

Issue facebook/react-native#31245 just got a resolution!
Please please cherry pick facebook/react-native@b0e8c1e and thank you :-)

@kelset the issue that @mikehardy mentioned seems to be a pretty big blocker too judging by the amount of emojis the issue got in that short time frame. Maybe its worth doing a speedy release here too?

@kelset sorry for interruption but any updates to this? Any chance or ETA when this could be released because I think lots of people are having trouble because of this. Tnx!

@savv
Copy link

@savv savv commented May 17, 2021

It would be great to have an ETA, if it's non-committal. It would help us decide whether we should push through for 0.64, or stay with 0.63 for our next release, which we are trying to get out. We are also blocked on facebook/react-native#31245

@kelset
Copy link
Member Author

@kelset kelset commented May 17, 2021

Folks I share your frustration but I hope you can understand that I'm not working on this full time, neither is @grabbou - and the FB team asked us to focus our (limited) attention to 0.65.

I want to get around to do the 0.64.2 release at some point but I don't know when I will have time for it.

@savv
Copy link

@savv savv commented May 18, 2021

Hi, if it helps, I made a branch where I started from tag v0.64.1 and cherry-picked the seven commits listed at the top, under "Ready for cherry-pick:". I ran node ./scripts/publish-npm.js --nightly and it seems to have built (of course, it failed uploading :-)).

The branch is here: https://github.com/savv/react-native/tree/savv-0-64-2

@yedidyak
Copy link

@yedidyak yedidyak commented May 20, 2021

Hi, facebook/react-native#31245 is a serious issue for us as well, it's blocking our adoption of 0.64. Is there any ETA for this to be released?

Thanks for all you do for the community!

@Shahafku
Copy link

@Shahafku Shahafku commented May 20, 2021

Hi, thanks a lot for all your amazing work

We're experiencing a serious issue with facebook/react-native#31245, which is affecting our users badly.
An ETA for this will be appricicated

Thanks

@mikehardy
Copy link

@mikehardy mikehardy commented May 20, 2021

That's an issue link not a commit hash? There are no etas in open source

@yedidyak
Copy link

@yedidyak yedidyak commented May 20, 2021

This is the commit that solves it, in master: facebook/react-native@b0e8c1e, it was referenced above.

I appreciate that there's no definite ETA, but could you add any information that would help us understand whether we should be reverting to 0.63 or to hope for a new release containing this soon?

Thanks again

@mikehardy
Copy link

@mikehardy mikehardy commented May 20, 2021

There is a comment saying they are focused on 65. I would not wait or use the fork above.

@yedidyak
Copy link

@yedidyak yedidyak commented May 20, 2021

I understand, but this isn't a new feature, it's a single commit to solve a serious regression introduced in 0.64.0. Wouldn't it make sense to solve it in 0.64.2 without adding new features?

@mikehardy
Copy link

@mikehardy mikehardy commented May 20, 2021

Discussions of 'should' in open source prompt invitations to commit yourself to the ongoing maintenance of the project, to handle releases etc without any form of compensation other than reputational benefit, over long periods of time. Is that what you intend? If not there is a reputational cost to asking other uncompensated individuals repeatedly to work for you. That's just open source. Above, someone has already done the open source thing and provided a temporary fork, which is magnificent. Revert, do the work, or wait. I'm not aware of other open source options.

@savv
Copy link

@savv savv commented May 20, 2021

Hi all, I'm trying publish a temporary version, which is still building here. It cherrypicks only facebook/react-native@b0e8c1e into stable-0.64 (i.e. into 0.64.1).

If it succeeds, you will be able to use it like this in your package.json: "react-native": "npm:react-native-savv@0.64.2". I haven't tested it yet, but will report back if it works!

I followed the steps in publish-npm.js:

  1. Developer: git checkout 0.XY-stable
  2. git cherry-pick b0e8c1e
  3. change package name to react-native-savv so I can publish my own NPM
  4. push to my own remote
  5. create a release v0.64.2 here

@savv
Copy link

@savv savv commented May 20, 2021

Update: I published react-native-savv@0.64.2 and successfully built an ios/android app, but haven't tested it extensively yet.

@DanijelBojcic
Copy link

@DanijelBojcic DanijelBojcic commented May 24, 2021

Unfortunately Android release build doesn't work with react-native-savv@0.64.2

@savv
Copy link

@savv savv commented May 24, 2021

Unfortunately Android release build doesn't work with react-native-savv@0.64.2

Hi Danijel, what failed for you? I have so far been able to build an app and it went through testing successfully.

@DanijelBojcic
Copy link

@DanijelBojcic DanijelBojcic commented May 24, 2021

It would just hang on the splash screen.
Luckily I managed to fix it.
If in monorepo make sure you update every react-native version to "npm:react-native-savv@0.64.2".
Then I got Invariant Violation: Module RCTDeviceEventEmitter is not a registered callable module and fixed it with facebook/react-native#28801 (comment)

Don't know if it will break something else, if yes I will update this comment.

@savv
Copy link

@savv savv commented May 24, 2021

Thanks for the report. Do let me know if you run into any other issues so we all know if it's safe to use!

@kelset
Copy link
Member Author

@kelset kelset commented May 26, 2021

Hey folks, I've been working on this patch (finally got some time 😅) and here's a brief update: I managed to cherry pick cleanly:

And sadly these other commits had conflicts so I didn't cherry pick them (at least for now):

Now we'll proceed with testing, next week it's likely that we'll publish the patch release.

@satya164

This comment has been hidden.

@sunnylqm

This comment has been hidden.

@satya164

This comment has been hidden.

@kelset
Copy link
Member Author

@kelset kelset commented May 27, 2021

@satya164 @sunnylqm I've tested locally on my machine and I can't repro - also, given how Satya is on Node 14 and I'm on Node 12 I think we can exclude that it's "a known Node 12 issue".

Moreover, bumping to codegen 0.0.7 is something that we can't do as it was a cause of issues during the RC phase (we had to rollback from it: facebook/react-native@e7e4b00) so I'll hide the comments to keep the conversation on the next patch. That said if there's an issue in the main repo about it please keep the investigation going over there 🤗 There's probably something going on that should be addressed

@danilobuerger
Copy link

@danilobuerger danilobuerger commented May 27, 2021

Please cherry-pick facebook/react-native@d754bde

@kelset
Copy link
Member Author

@kelset kelset commented May 27, 2021

@danilobuerger I was able to cherry pick cleanly so added to the list above 👍

@aliaksandr-kazarez
Copy link

@aliaksandr-kazarez aliaksandr-kazarez commented May 28, 2021

Could you please cherry-pick facebook/react-native@6ccd0cd

@danilobuerger
Copy link

@danilobuerger danilobuerger commented May 28, 2021

@aliaksandr-kazarez do you know why the build tools weren't updated to api level 30?

@aliaksandr-kazarez
Copy link

@aliaksandr-kazarez aliaksandr-kazarez commented May 29, 2021

Nope unfortunately. Would try to figure it out.

@mikehardy
Copy link

@mikehardy mikehardy commented May 29, 2021

I would more be curious why buildTools are still in there. They shouldn't be, they actually trigger android studio lint. But that's for a react-native issue

@kelset
Copy link
Member Author

@kelset kelset commented Jun 1, 2021

for future memory, this one is something we should try to cherry pick: facebook/react-native#31622

re:

Could you please cherry-pick facebook/react-native@6ccd0cd

No I don't think we'd cherry pick that into a patch release, since it's a bump mostly for CI stuff and the template. You'd still have to do the bump on your local project.

@imshreyansh
Copy link

@imshreyansh imshreyansh commented Jun 1, 2021

@kelset Sir when will the patch release 0.64.2 will be available ?

@walterholohan
Copy link

@walterholohan walterholohan commented Jun 2, 2021

facebook/react-native#31245 is also blocking us from upgrading to 0.64. 🙏 for 0.64.2 soon

@dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Jun 3, 2021

@kelset
Copy link
Member Author

@kelset kelset commented Jun 3, 2021

@dulmandakh cherry picked and also did a local version of facebook/react-native@cdd0256 to address a CLI small issue.

Testing ongoing

@kelset
Copy link
Member Author

@kelset kelset commented Jun 3, 2021

hey folks - 0.64.2 is out now with a few fixes, in particular the JSI one facebook/react-native@b0e8c1e so I hope it will be a good release for y'all 🤗

@kelset kelset closed this Jun 3, 2021
@react-native-community react-native-community locked as resolved and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet