Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.59.x Discussion #79

Closed
grabbou opened this issue Jan 17, 2019 · 154 comments
Closed

0.59.x Discussion #79

grabbou opened this issue Jan 17, 2019 · 154 comments

Comments

@grabbou
Copy link
Contributor

@grabbou grabbou commented Jan 17, 2019

Conversation on this thread are limited to 0.59 releases, major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.59 RC cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

@kelset

This comment has been hidden.

@grabbou

This comment has been hidden.

@yurykorzun

This comment was marked as off-topic.

@kelset

This comment has been hidden.

@rbalch

This comment was marked as off-topic.

@grabbou

This comment has been hidden.

@Eyesonly88

This comment was marked as off-topic.

@kelset

This comment has been hidden.

@fbartho

This comment has been hidden.

@hramos

This comment has been hidden.

@yurykorzun

This comment has been hidden.

@chris-hinds

This comment has been hidden.

@grabbou

This comment has been hidden.

@ithustle

This comment was marked as off-topic.

@grabbou

This comment has been hidden.

@matthargett

This comment has been hidden.

@kanalasumant

This comment has been hidden.

@gtebbutt

This comment has been hidden.

@matthargett

This comment has been hidden.

@hramos

This comment has been hidden.

@matthargett

This comment has been hidden.

@objectiveSee

This comment has been hidden.

@sijad

This comment has been hidden.

@grabbou

This comment has been hidden.

@akshetpandey

This comment has been hidden.

@eladcandroid

This comment has been hidden.

@kelset

This comment has been hidden.

@hramos

This comment has been hidden.

@hramos

This comment has been hidden.

@shawnthye
Copy link

@shawnthye shawnthye commented Mar 1, 2019

Hi, will this facebook/react-native#23430 come into the next patch?

@vdlindenmark

This comment has been hidden.

@grabbou
Copy link
Contributor Author

@grabbou grabbou commented Mar 1, 2019

@satyen-progton

This comment was marked as off-topic.

@hramos

This comment has been hidden.

@kelset

This comment has been hidden.

@furkancelik

This comment was marked as off-topic.

@kelset

This comment has been hidden.

@OlivierFreyssinet
Copy link

@OlivierFreyssinet OlivierFreyssinet commented Mar 4, 2019

Hi! Is this facebook/react-native@58c3a4c going to be in 0.59 ?

@sunnylqm
Copy link
Contributor

@sunnylqm sunnylqm commented Mar 5, 2019

Hi can you cherry pick this one facebook/react-native@d2153fc

@tijp
Copy link

@tijp tijp commented Mar 5, 2019

Hello! Can facebook/react-native#23446 be cherry picked for 0.59?

@ChrisEdson

This comment has been hidden.

@grabbou

This comment has been hidden.

@matei-radu

This comment has been hidden.

@grabbou

This comment has been hidden.

@hramos

This comment has been hidden.

@matei-radu

This comment has been hidden.

@grabbou
Copy link
Contributor Author

@grabbou grabbou commented Mar 8, 2019

We decided to wait with 0.59 stable release till next week (Monday/Tuesday) till there's more context on the aforementioned regression. We want to be sure whether it's a major that should be fixed before a stable release happen or a minor that we can disclose in the changelog as a "known issue".

@cjroth

This comment was marked as off-topic.

@kelset
Copy link
Member

@kelset kelset commented Mar 9, 2019

@cjroth given that, as you posted in the issue, this seems to be a long lasting issue with RN (going as far as 0.57 at least) it won’t be considered a blocker for the release on 0.59.0. OFC any help you can provide over there in terms of debugging it and PRs will be super appreciated, and we’ll see how we can prioritize it against the current roadmap & pipeline.

Also, the PR with the fix of the blocker mentioned above is being imported, so hopefully we can still release 0.59.0 next week.

@cjroth
Copy link

@cjroth cjroth commented Mar 9, 2019

@kelset sweet, excited about 0.59.0, thanks for the reply. I wish I had more time and was better at the native side of things. If I can find some time I might poke around but I already spent a few days tracking it down so not sure if I'll be able to. Just wanted to make sure some folks in here were aware of it!

@grabbou
Copy link
Contributor Author

@grabbou grabbou commented Mar 11, 2019

Turned out the issue was not really major. Anyway, since the PR is already being imported (facebook/react-native#23823), we're going to wait for it to land and then, cut the RC.

I am hoping that means "today"

Update: Going to release tomorrow due to some minor issues on CircleCI caused by few of the cherry-picks.

@krunalsshah

This comment was marked as off-topic.

@grabbou
Copy link
Contributor Author

@grabbou grabbou commented Mar 12, 2019

Closing this one as 0.59.0 is out. Let's continue discussions in a separate issue.

@grabbou grabbou closed this Mar 12, 2019
@react-native-community react-native-community locked as resolved and limited conversation to collaborators Mar 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet