Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.60.x Discussion #99

Closed
grabbou opened this issue Mar 12, 2019 · 19 comments

Comments

Projects
None yet
@grabbou
Copy link
Contributor

commented Mar 12, 2019

Please note that we haven't cut 0.60-stable branch yet.

The latest release candidate is 0.59.0-rc.3. You can track it's progress here: #79

This thread is to inform you when next release candidate is going to happen. We are checking whether there is any "work-in-progress" that we should be aware of and wait before we make a next Release Candidate.

The plan is to release 0.60.0-rc.0 this week.

@el-lsan

This comment was marked as outdated.

Copy link

commented Mar 12, 2019

@grabbou

The latest release candidate is 0.59.0-rc.3. You can track it's progress here.

Please fix the link.

@grabbou

This comment was marked as resolved.

Copy link
Contributor Author

commented Mar 12, 2019

Fixed. Looks like Github UI had some issues.

@pvinis

This comment has been minimized.

Copy link

commented Mar 12, 2019

Can I already ask for facebook/react-native#23691? 🙏

@grabbou

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

0.60 is not cut yet, so this will land.

@dxhung87

This comment was marked as off-topic.

Copy link

commented Mar 14, 2019

Size APK sign can smaller?? In RN 0.57 APK size is 8MB in RN 0.58 APK size is 16MB and in RN 0.59.0 APK size is 30MB. For simple app, it's too large.

@mikehardy

This comment was marked as resolved.

Copy link

commented Mar 14, 2019

Size APK sign can smaller?? In RN 0.57 APK size is 8MB in RN 0.58 APK size is 16MB and in RN 0.59.0 APK size is 30MB. For simple app, it's too large.

Google mandates 64-bit support for apps starting 2019-08, so to meet that React-Native started specifying the 64-bit ABIs, and then included an updated JSC. Each of those increased the size a lot, but mostly in the per-ABI parts of the APK.

You'll want to generate per-ABI APKs for Google to serve so that your end users only download the ABI they need - meaning your actual end-user downloads might be something like 30% of the size of what you see in the universal debug APKs.

https://developer.android.com/studio/build/configure-apk-splits

The output of 'react-native init' produces a Gradle file that seems to implement this so when you do an android release build there should be multiple variants generated, at least one for each ABI.

You add each of those to your app release on the Play Store and Google will deliver the right one to the user.

More info here https://developer.android.com/google/play/publishing/multiple-apks

And if I'm wrong in any way someone please correct me of course :-). Cheers.

@guhungry

This comment was marked as resolved.

Copy link

commented Mar 14, 2019

@dxhung87 React Native add support for Android App Bundle in 0.58 so it's a lot easier to optimise download for end user if you publish app via Play Store else you might need multiple apks instead.

@thinkzh

This comment was marked as off-topic.

Copy link

commented Mar 14, 2019

在Android9.0系统上 ,text多行显示时,最后一行显示一半,好像整个text不计算行间距似的

@dxhung87

This comment was marked as off-topic.

Copy link

commented Mar 14, 2019

Thanks @mikehardy and @guhungry,
I known Android App Bundle and some time i upload multiple apks file too. But I thinks size of apks file build by React Native is larger than native too much. If size of it grow such I things React Native isn't good choice for simple application in Android. I hope it's smaller in new version.

@thinkzh

This comment was marked as off-topic.

Copy link

commented Mar 14, 2019

On Android 9.0, when text is displayed in multiple rows, the last line is displayed in half, as if the entire text does not calculate the row spacing.

@cihati

This comment was marked as resolved.

Copy link

commented Mar 14, 2019

@mikehardy thanks for the explanation. It'd be super useful to have this information in the official RN docs.

@kelset

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

@dxhung87 @thinkzh this is not the correct place for those conversation - please use the issue section of the main repo. That said, thanks @mikehardy for explaining the change 🤗

@hramos

This comment has been minimized.

Copy link
Collaborator

commented Mar 15, 2019

Please cherry-pick facebook/react-native@d4aa1e7, as it contains a fix for an issue introduced in facebook/react-native@d2153fc#diff-a1e6ca3a6b1647be95d97e7890bcc11c that affects devices using Android API < 26.

@elucaswork

This comment has been minimized.

Copy link

commented Mar 15, 2019

Please cherry-pick those updates to AccessibilityInfo facebook/react-native@0090ab3
facebook/react-native@40de049

@renalpraba

This comment has been minimized.

Copy link

commented Mar 16, 2019

What 0.60 likely will have? and is it will have any breaking changes?

@grabbou

This comment has been minimized.

Copy link
Contributor Author

commented Mar 16, 2019

0.60 hasn’t been released yet as we are waiting for some commits to land. Please hold on with requesting cherry picks as there’s no release yet.

I will keep you updated. Current estimate is next Friday, 22 March

@elucaswork

This comment has been minimized.

Copy link

commented Mar 20, 2019

please cherry-pick this one facebook/react-native@fa426cf adding openSettings method to Linking module

@kelset

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

Hey everyone - we have reached a decision on our approach to the releases (you can read the details here).

Related to it, we have decided to postpone the release of 0.60 of around a couple weeks: we will remove the current 0.60 branch and re-cut it in the near future. We'll open a new issue once it's cut, in order to focus on improving 0.59 in the meantime.

@kelset kelset closed this Mar 21, 2019

@react-native-community react-native-community locked as resolved and limited conversation to collaborators Mar 21, 2019

@grabbou

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

Important note: many of you requested cherry-picks even though 0.60 wasn't released yet. If you need certain features or fixes and you think they are important to the community, please comment about them in 0.59 issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.