New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIXED, RELEASE IN V3.0.0] UIWebView iOS Deprecated API Usage Warning ITMS-90809 #756
Comments
I could submit a PR for that but then the Android part would also have to be asynchronous (as |
Dang. This may be the time to finally do the big promise-based breaking change. I've got a bit of time this morning maybe I can crank it out. I don't want to just trickle in async changes when everything needs to go async really. @Johan-dutoit / @radko93 I read through the linked discussion and did not see any statement on when it would become a hard requirement and fail an app store build vs just a warning. Could one of you guys dig and find when this becomes a hard fail? That will help prioritize |
@radko93 I would definitely appreciate a PR that implemented the required API change - while I may not ingest it as is (because I want to do all the async changes at once) it would be really really helpful to me to have the ObjC portion of the PR from someone who knew what they were doing :-). If you converted it to a Promise at the same time I could probably just include the commit raw into the promise-ify commit stream anyway, to maintain attribution |
@mikehardy can we assume it's going to be with iOS 13? i.e. anything that targets iOS 13, which would mean less than 2 months away. The documentation currently states the following, although we will have to check back once 13 is released. Other than that, I've been unable to find a concrete timeline. |
No one seems to know concretely in the react-native-community Discord chats or the webview component or stackoverflow. I think that's a reasonable guess though, thank you. If anyone posted the recommended ObjC changes that would help me |
This is merged and will release with v3 |
When will v3 be released? I am really in need @mikehardy |
No, no you aren't really in need. You're strongly in want, nothing more. It's a warning, the app store will still accept submissions. Asking for your free stuff faster is not polite in the open source world :-) That said, I might have a release candidate up tomorrow morning. But if I met my untimely demise and you really thought you were in need for some reason, you could use patch-package to integrate the merged patch, or fork. You'd be fine because the source is open and you're a programmer |
This is released. If anyone wants to try v3.0.0-beta.1 of react-native-device-info is up tagged on npm as |
I am planning on letting it incubate at least a couple days - plenty of time for good feedback. Final release maybe early next week. But you can rely on the v3 git branch, or the |
Waiting for the v3 release to be stable. Btw I don't think your "No, no you aren't really in need. You're strongly in want, nothing more. It's a warning, the app store will still accept submissions." is valid. The Apple mail explicitly mentioned "Apple will stop accepting submissions of apps that use UIWebView APIs." |
@rnnyrk tell me the date and I'll listen, until then my statement stands. 3.0.0-rc.1 has had no issues logged so I believe it's stable though I may add a companion sync API to it. |
Been using (only like 5% of it anyway) 3.0.0-rc.1 for a while now and no issues yet. |
@mikehardy I didn't mean this as an offense in any way. Just state what the Apple mail mentioned, which made me a little scared for my release. Updated to the RC now. Seems to run without any issues. |
No worries @rnnyrk I don't take offense but I must be firm in my stance as the project is huge and wishy-washy remarks result in comment discussions that take time I don't care to spend ;-). So I wanted to be very concrete, for others that might come. So to restate (since this will be the last comment now): Apple will continue accepting app submissions for now. There is no known date when they will stop. It is suspected they may stop when iOS 13 is in full release but that is a guess. And of course we are working to resolve it. Thanks everyone for the RC1 testing. I had so much difficulty with a semi-synchronous code-base and the fully async RC1 that I'm adding a parallel sync API for RC2 which is unfortunately a big change so I'll really appreciate further testing once it's out. Please follow along on #307 and #760 Thanks |
email: We identified one or more issues with a recent delivery for your app, "****" 1.0.0 (1.0.0). Your delivery was successful, but you may wish to correct the following issues in your next delivery: ITMS-90809: Deprecated API Usage - Apple will stop accepting submissions of apps that use UIWebView APIs . See https://developer.apple.com/documentation/uikit/uiwebview for more information. After you’ve corrected the issues, you can use Xcode or Application Loader to upload a new binary to App Store Connect. Best regards, The App Store Team So, currently my app is blocked completely due to the uiwebview thingy. I'm assuming this is across the board now. |
@kaphoto this is thoroughly resolved through the ecosystem, the relevant issue in the react-native-webview repository has some good strategies to discover why you are still referencing the symbol, if you are. But the symbols are no longer in use in this repo. |
Find solution here! |
that is resolved for react-native-webview, but what to do for resolving the same for react-native-device-info? |
In my project I use |
THIS HAS A MERGED FIX - IT WILL RELEASE IN V3.0.0 HERE*
See react-native-webview/react-native-webview#819
I have not yet submitted a new version of the app, but I searched my node_modules and found that this module referenced UIWebView too.
See: https://github.com/react-native-community/react-native-device-info/blob/8efe2efaba6b01a1d48a0238ff91ab8e9d39f4ab/ios/RNDeviceInfo/RNDeviceInfo.m#L118
The text was updated successfully, but these errors were encountered: