fix: use promiseWrapper for all rejections in pick, pickDirectory, and saveDocument #896
+11
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d saveDocument The pick, pickDirectory, and saveDocument functions were using both promiseWrapper.trySetPromiseRejectingIncoming() to set the promise and direct promise.reject() calls in catch blocks. This led to an inconsistent state where the promiseWrapper would still hold a reference to the rejected promise, causing subsequent calls to automatically reject. Changed all promise.reject() calls in catch blocks to use promiseWrapper.reject() to ensure proper cleanup of the wrapper state.
🦋 Changeset detectedLatest commit: be41a87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Updated promise handling in pick, pickDirectory, and saveDocument functions.
Member
Author
|
Claude code works pretty well for coding on the go😃 |
vonovak
deleted the
claude/fix-kotlin-promise-handling-01Wgj9vGKNNaiqibJ2h2rb6d
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pick, pickDirectory, and saveDocument functions were using both
promiseWrapper.trySetPromiseRejectingIncoming() to set the promise
and direct promise.reject() calls in catch blocks. This led to an
inconsistent state where the promiseWrapper would still hold a reference
to the rejected promise, causing subsequent calls to automatically reject.
Changed all promise.reject() calls in catch blocks to use
promiseWrapper.reject() to ensure proper cleanup of the wrapper state.