Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added New Component: CircularSlider #1

Merged
merged 7 commits into from Apr 20, 2021
Merged

Added New Component: CircularSlider #1

merged 7 commits into from Apr 20, 2021

Conversation

arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Apr 18, 2021

  • Component
  • Docs
  • Tests
  • Demo

Ref
https://github.com/react-native-elements/react-native-elements/issues/2542

1618751702674.mp4

@codecov
Copy link

codecov bot commented Apr 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (next@acfb76f). Click here to learn what that means.
The diff coverage is 58.18%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next       #1   +/-   ##
=======================================
  Coverage        ?   58.18%           
=======================================
  Files           ?        1           
  Lines           ?       55           
  Branches        ?       28           
=======================================
  Hits            ?       32           
  Misses          ?       19           
  Partials        ?        4           
Impacted Files Coverage Δ
src/CircularSlider/CircularSlider.tsx 58.18% <58.18%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acfb76f...627eb14. Read the comment docs.

@arpitBhalla arpitBhalla marked this pull request as draft April 18, 2021 11:35
@arpitBhalla arpitBhalla marked this pull request as ready for review April 18, 2021 17:19
@pranshuchittora pranshuchittora merged commit 86f9797 into react-native-elements:next Apr 20, 2021
@pranshuchittora
Copy link
Member

As the project is in the initial phase, I am not reviewing it deeply as the idea is to move fast and break things :)

@arpitBhalla arpitBhalla deleted the circularSlider branch April 20, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants