Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PriceCard props to accept style objects #1231

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Refactor PriceCard props to accept style objects #1231

merged 1 commit into from
Jun 4, 2018

Conversation

Gregjarvez
Copy link
Collaborator

closes #1212

@react-native-elements-ci
Copy link
Collaborator

react-native-elements-ci commented May 26, 2018 •
edited
Loading

Example app for the last commit (e2808d5):

QR Code

https://exp.host/@rn-elements/react-native-elements-app?release-channel=e2808d5e6c6c1414a4cf34d983226a6c6aad803d

@codecov
Copy link

codecov bot commented May 26, 2018 •
edited
Loading

Codecov Report

Merging #1231 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1231   +/-   ##
=======================================
  Coverage   71.13%   71.13%           
=======================================
  Files          33       33           
  Lines         589      589           
  Branches       88       88           
=======================================
  Hits          419      419           
  Misses        142      142           
  Partials       28       28
Impacted Files Coverage Δ
src/pricing/PricingCard.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1da007e...e2808d5. Read the comment docs.

iRoachie
iRoachie reviewed May 28, 2018
View reviewed changes
Copy link
Collaborator

@iRoachie iRoachie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeet 💯. Just need to update the docs and the typescript definitions.

iRoachie
iRoachie requested changes May 30, 2018
View reviewed changes
src/index.d.ts Outdated Show resolved Hide resolved
docs/pricing.md Outdated Show resolved Hide resolved
@iRoachie iRoachie merged commit a521fc5 into next Jun 4, 2018
@iRoachie iRoachie deleted the refactor-priceitem-props branch June 4, 2018 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iRoachie iRoachie iRoachie approved these changes

Assignees
No one assigned
Labels
✨ Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gregjarvez @react-native-elements-ci @iRoachie