Add Theming #1454
Merged
Add Theming #1454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example app for the last commit (a5dce79): |
Codecov Report
@@ Coverage Diff @@
## next #1454 +/- ##
=========================================
+ Coverage 71.3% 74.79% +3.49%
=========================================
Files 30 33 +3
Lines 568 615 +47
Branches 84 88 +4
=========================================
+ Hits 405 460 +55
+ Misses 136 132 -4
+ Partials 27 23 -4
Continue to review full report at Codecov.
|
xavier-villelegier
approved these changes
Oct 10, 2018
| ...attributes | ||
| } = props; | ||
|
|
||
| if (element) return element; | ||
|
|
||
| let childElement = ( | ||
| <Text style={[styles.text, textStyle && textStyle]}>{value}</Text> | ||
| <Text style={StyleSheet.flatten([styles.text, textStyle && textStyle])}> |
There was a problem hiding this comment.
Finally !! 👏 We should have flattened all styles a while ago.
|
this is so awesome ! |
|
Alright! ThemeProvider now optional if you don't want theming. That's means no more breaking change! |
|
@iRoachie yes!! that's huge! Thanks for putting in the extra work to make that possible, I know a lot of users would appreciate that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #216
Finally, after countless ages, theming is here 🎉!
Not just colours but:
EVERY, SINGLE, PROP
Exports three new utils:
Preview
Breaking Changes
This is a massive breaking change, all apps will need up wrap their Top level component with the<ThemeProvider />