Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update component prop to Component #1479

Merged
merged 7 commits into from
Oct 17, 2018
Merged

Update component prop to Component #1479

merged 7 commits into from
Oct 17, 2018

Conversation

iRoachie
Copy link
Collaborator

Change all components that have the component prop to Component as per convention

@react-native-elements-ci
Copy link
Collaborator

react-native-elements-ci commented Oct 17, 2018

@codecov
Copy link

codecov bot commented Oct 17, 2018

Codecov Report

Merging #1479 into next will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             next   #1479     +/-   ##
========================================
- Coverage   74.79%   74.5%   -0.3%     
========================================
  Files          33      33             
  Lines         615     608      -7     
  Branches       88      85      -3     
========================================
- Hits          460     453      -7     
  Misses        132     132             
  Partials       23      23
Impacted Files Coverage Δ
src/list/ListItem.js 100% <ø> (ø) ⬆️
src/social/SocialIcon.js 90.9% <ø> (-0.76%) ⬇️
src/buttons/ButtonGroup.js 72.22% <ø> (ø) ⬆️
src/avatar/Avatar.js 30% <ø> (ø) ⬆️
src/icons/Icon.js 100% <ø> (ø) ⬆️
src/checkbox/CheckBox.js 100% <ø> (ø) ⬆️
src/badge/badge.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb3c519...df46c67. Read the comment docs.

@iRoachie iRoachie merged commit 3582b78 into next Oct 17, 2018
@iRoachie iRoachie deleted the componentProps branch October 17, 2018 10:07
iRoachie added a commit that referenced this pull request Oct 28, 2018
* refactor(Avatar): Change component prop to Component

* refactor(Badge): Change component prop to Component

* refactor(ButtonGroup): Change component prop to Component

* refactor(CheckBox): Change component prop to Component

* refactor(Icon): Change component prop to Component

* refactor(ListItem): Change component prop to Component

* refactor(SocialIcon): Change component prop to Component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants