Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AntDesign to icons in src/helps/getIconType.js #1529

Merged
merged 12 commits into from
Oct 31, 2018
Merged

Add AntDesign to icons in src/helps/getIconType.js #1529

merged 12 commits into from
Oct 31, 2018

Conversation

osdnk
Copy link
Contributor

@osdnk osdnk commented Oct 30, 2018 •
edited
Loading

Base on: https://github.com/react-native-training/react-native-elements/pull/1474

Motivation

Wish to use new icon set from RNVI

Changes

Add proper import and bump RNVI version

@osdnk
Copy link
Contributor Author

osdnk commented Oct 30, 2018

cc @d-p-s @iRoachie

iRoachie
iRoachie requested changes Oct 30, 2018
View reviewed changes
Copy link
Collaborator

@iRoachie iRoachie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @osdnk thanks for submitting.

Just a few things left to do:

@iRoachie
Copy link
Collaborator

Also add it to the list of icons here https://github.com/react-native-training/react-native-elements/blob/next/docs/icon.md#available-icon-sets

@iRoachie iRoachie mentioned this pull request Oct 30, 2018
Closed
@osdnk
Copy link
Contributor Author

osdnk commented Oct 30, 2018

Ok, I'll do it soon

@codecov
Copy link

codecov bot commented Oct 30, 2018 •
edited
Loading

Codecov Report

Merging #1529 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1529   +/-   ##
=======================================
  Coverage   75.49%   75.49%           
=======================================
  Files          33       33           
  Lines         612      612           
  Branches       85       85           
=======================================
  Hits          462      462           
  Misses        129      129           
  Partials       21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24fbebc...9f5174f. Read the comment docs.

@osdnk
Copy link
Contributor Author

osdnk commented Oct 30, 2018

@iRoachie
Please take a look

iRoachie
iRoachie reviewed Oct 30, 2018
View reviewed changes
@iRoachie @osdnk
Update docs/icon.md
9f5174f 
Co-Authored-By: osdnk <micosa97@gmail.com>
@osdnk
Copy link
Contributor Author

osdnk commented Oct 30, 2018

Done

@iRoachie
Copy link
Collaborator

iRoachie commented Oct 30, 2018 •
edited
Loading

Lastly could you do a rebase from the next branch? Seems you have some unwanted commits.

@osdnk
Copy link
Contributor Author

osdnk commented Oct 30, 2018

I could do it tommorow. Wouldn't you like simply squash my commits?

@iRoachie
Copy link
Collaborator

Nvmd it's fine.

@iRoachie iRoachie merged commit 83a8625 into react-native-elements:next Oct 31, 2018
@iRoachie
Copy link
Collaborator

Thanks for pulling this off 💯 Great job

@iRoachie
Copy link
Collaborator

iRoachie commented Oct 31, 2018 •
edited
Loading

We may actually have to delay this a bit, AntDesign isn't available through expo, and it throws an error.

@osdnk
Copy link
Contributor Author

osdnk commented Oct 31, 2018

@iRoachie
I have contacted with Expo team and they do confirm that it will be available in a new release (31.0.0), which will be available soon (it's matter of few days)
CC: @tsapeta

@iRoachie
Copy link
Collaborator

Thanks!

nurdiansyah added a commit to deboxlibrary/react-native-elements that referenced this pull request Nov 6, 2018
@nurdiansyah
Merge commit '0126436f5f0f37e0340b0c1da32bdea5605cb6df'
6a921b4 
* commit '0126436f5f0f37e0340b0c1da32bdea5605cb6df': (43 commits)
  feat(Card): Remove flexDirection prop
  feat(Card): Remove fontFamily prop
  test: Add tests for withTheme
  test: Fix searcbar error being logged to console
  fix: Hoist statics for withTheme hoc (react-native-elements#1554)
  fix: Use library for calculating statusBar height (react-native-elements#1553)
  ref: Badge component (react-native-elements#1545)
  Set default prop for type (react-native-elements#1546)
  docs: Fix paragraphs links in docs (react-native-elements#1536)
  docs(website): Make image preview section reusable
  feat: Add button types (react-native-elements#1540)
  fix: Rounded buttons on android now work correctly (react-native-elements#1538)
  ci: Run travis against node stable
  fix: Make button height consistent when using loading
  ci: Update husky and lint-staged
  feat: Add AntDesign to list of available icon sets (react-native-elements#1529)
  docs(website): Add central place to show supported icon sets (react-native-elements#1532)
  feat(Input): Allow label to be a React element (react-native-elements#1531)
  ci: Remove expo ci from PRs (react-native-elements#1528)
  fix(Button): Make the padding consistent (react-native-elements#1505)
  ...
@iRoachie iRoachie mentioned this pull request Nov 12, 2018
Closed
@Monte9
Copy link
Collaborator

Monte9 commented Jan 27, 2019

This fixed it for me: yarn add @expo/vector-icons

expo/expo#1083 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iRoachie iRoachie iRoachie approved these changes

Assignees
No one assigned
Labels
✨ Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@osdnk @iRoachie @Monte9 @d-p-s