feat: Add button types #1540
Merged
feat: Add button types #1540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still to add tests, and screen shots to docs. |
|
Looks good. And I assume Can you also share code snippets for those screenshots? would help to see what props you are using to achieve that. |
Monte9
reviewed
Oct 31, 2018
| @@ -32,6 +32,7 @@ | |||
| "logo": "https://opencollective.com/react-native-elements/logo.txt" | |||
| }, | |||
| "dependencies": { | |||
| "color": "^3.1.0", | |||
There was a problem hiding this comment.
what does this packages provide us?
There was a problem hiding this comment.
It's a module to work with colors as strings and perform operations like lighten, darken that you'd normally have with sass etc.
|
Snippets are super simple. Used the theme provider. const theme = {
Button: {
// disabled: true,
// raised: true,
buttonStyle: {
width: 150,
},
containerStyle: {
margin: 16,
},
},
};<ThemeProvider theme={theme}>
<Button title="Solid" />
<Button type="clear" title="Clear" />
<Button type="outline" title="Outline" />
</ThemeProvider> |
Codecov Report
@@ Coverage Diff @@
## next #1540 +/- ##
==========================================
+ Coverage 75.49% 75.72% +0.23%
==========================================
Files 33 33
Lines 612 618 +6
Branches 85 86 +1
==========================================
+ Hits 462 468 +6
Misses 129 129
Partials 21 21
Continue to review full report at Codecov.
|
Raised clear button looks the same as solid button
Add images show button type and states. Also cleanup prop descriptions
nurdiansyah
added a commit
to deboxlibrary/react-native-elements
that referenced
this pull request
Nov 6, 2018
* commit '0126436f5f0f37e0340b0c1da32bdea5605cb6df': (43 commits) feat(Card): Remove flexDirection prop feat(Card): Remove fontFamily prop test: Add tests for withTheme test: Fix searcbar error being logged to console fix: Hoist statics for withTheme hoc (react-native-elements#1554) fix: Use library for calculating statusBar height (react-native-elements#1553) ref: Badge component (react-native-elements#1545) Set default prop for type (react-native-elements#1546) docs: Fix paragraphs links in docs (react-native-elements#1536) docs(website): Make image preview section reusable feat: Add button types (react-native-elements#1540) fix: Rounded buttons on android now work correctly (react-native-elements#1538) ci: Run travis against node stable fix: Make button height consistent when using loading ci: Update husky and lint-staged feat: Add AntDesign to list of available icon sets (react-native-elements#1529) docs(website): Add central place to show supported icon sets (react-native-elements#1532) feat(Input): Allow label to be a React element (react-native-elements#1531) ci: Remove expo ci from PRs (react-native-elements#1528) fix(Button): Make the padding consistent (react-native-elements#1505) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1525
Adds three button types to the Button component:
Changes
clearprop.Examples
Normal state
Raised state
Disabled state