feat(Header): Add background image#1556
feat(Header): Add background image#1556iRoachie merged 8 commits intoreact-native-elements:nextfrom MHase:header-background-image
Conversation
Codecov Report
@@ Coverage Diff @@
## next #1556 +/- ##
=======================================
Coverage 76.23% 76.23%
=======================================
Files 32 32
Lines 606 606
Branches 78 78
=======================================
Hits 462 462
Misses 125 125
Partials 19 19
Continue to review full report at Codecov.
|
|
Brooooo this PR is 🔥 |
iRoachie
left a comment
There was a problem hiding this comment.
There is one thing we way want to add. The ImageBackground component has a imageStyle prop which is used to style the Image https://facebook.github.io/react-native/docs/imagebackground#imagestyle.
So the user can access this, we may want to add backgroundImageStyle prop.
OR we could say that it has all the props from the ImageBackground Component and we'd need to update the typescript definitions to say that.

Issue: #1551
Added possibility to pass
backgroundImageprop which is simplysourceprop like inImagecomponent :) e.g. :