-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Header): Add background image #1556
feat(Header): Add background image #1556
Conversation
Codecov Report
@@ Coverage Diff @@
## next #1556 +/- ##
=======================================
Coverage 76.23% 76.23%
=======================================
Files 32 32
Lines 606 606
Branches 78 78
=======================================
Hits 462 462
Misses 125 125
Partials 19 19
Continue to review full report at Codecov.
|
Brooooo this PR is 🔥 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one thing we way want to add. The ImageBackground component has a imageStyle
prop which is used to style the Image https://facebook.github.io/react-native/docs/imagebackground#imagestyle.
So the user can access this, we may want to add backgroundImageStyle
prop.
OR we could say that it has all the props from the ImageBackground Component and we'd need to update the typescript definitions to say that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: #1551
Added possibility to pass
backgroundImage
prop which is simplysource
prop like inImage
component :) e.g. :