-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add React Native Ratings dependency #1671
Conversation
Codecov Report
@@ Coverage Diff @@
## next #1671 +/- ##
=========================================
+ Coverage 86.8% 87.84% +1.03%
=========================================
Files 34 33 -1
Lines 629 551 -78
Branches 81 66 -15
=========================================
- Hits 546 484 -62
+ Misses 70 56 -14
+ Partials 13 11 -2
Continue to review full report at Codecov.
|
Are there any docs that need to be updated? |
Ah good catch. Will update docs too. |
Alright, only thing left would be typescript definitions. Instead of adding them here I'll PR over on your repo. |
PR is here Monte9/react-native-ratings#36. So the process is:
|
@iRoachie I have published a new version of |
Alright @Monte9, off to you now to add the docs part for AirbnbRating and that should be it |
Awesome! Great work! 💯 I'll follow up with the docs tomorrow and we can merge it in. |
And we are merged!! 💯 Thanks for taking this on 🥇 |
This PR imports
Rating
fromreact-native-ratings
package and re-exports it through the index file.Context:
I created the react-native-ratings and wanted it to be available through RNE. Hence at the time, I copied the source over into RNE. But this has led to a disconnect between the two packages and hence we see a lot of issues related to something that might have already been fixed in the other package.
Hence as a work around, I am removing the source code for ratings from RNE and will just be maintaining it over at
react-native-ratings
. This way, all issues can be directed to that repo and closed here since they are non-actionable through RNE.Fixes: https://github.com/react-native-training/react-native-elements/issues/1630