-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added New component: LinearProgress #2867
Conversation
@flyingcircle Please Review, I havn't exported this from index.ts, tests are pending, Please Share your views |
WhatsApp.Video.2021-03-16.at.10.16.04.PM.mp4 |
Codecov Report
@@ Coverage Diff @@
## next #2867 +/- ##
==========================================
- Coverage 89.43% 88.76% -0.68%
==========================================
Files 47 48 +1
Lines 956 979 +23
Branches 372 382 +10
==========================================
+ Hits 855 869 +14
- Misses 66 74 +8
- Partials 35 36 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! I think the component should probably also extend ViewProps
. You'll definitely want people to be able to extend certain capabilities such as accessibility
to the component.
@flyingcircle Kindly review |
Code looks good just looking through it. I'll try to test it out myself here later on in a bit. |
@flyingcircle sure sir🙂 |
So I tested it out in iOS using your code. I made this adjustment: <Text>Linear Progress Indeterminate </Text>
<LinearProgress style={{ marginVertical: 10 }} color="red" />
<Text>Linear Progress Secondary color</Text>
<LinearProgress style={{ marginVertical: 10 }} color="secondary" />
<Text>Linear Progress with value</Text>
<LinearProgress
style={{ marginVertical: 10 }}
value={progress}
variant="determinate"
color="red"
/>
<Text>Linear Progress with value secondary color</Text>
<LinearProgress
style={{ marginVertical: 10 }}
value={progress}
variant="determinate"
color="secondary"
/>
<Button
disabled={progress > 0}
onPress={() => {
setProgress(0.00001);
}}
title={'Start Progress'}
containerStyle={{ margin: 10 }}
/>
<Button
disabled={progress === 0}
onPress={() => {
setProgress(0);
}}
title={'Restart'}
containerStyle={{ margin: 10 }}
/> I wasn't able to see the progress in the |
@flyingcircle I made Changes, Please Review |
Awesome! This looks great! I only see only minor change that should be made to the demo, but I'll post it there. Great work! |
@flyingcircle Thanku Sir |
What kind of change does this PR introduce?
New Component
LinearProgress
According to material desgin guidelines https://material.io/components/progress-indicators#linear-progress-indicators
Did you add tests for your changes?
Yupp
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Nope
Other information