-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added New Component: Speed dial #2896
Added New Component: Speed dial #2896
Conversation
@flyingcircle Kindly Review |
Codecov Report
@@ Coverage Diff @@
## next #2896 +/- ##
==========================================
- Coverage 88.20% 82.47% -5.74%
==========================================
Files 50 51 +1
Lines 1009 1067 +58
Branches 399 408 +9
==========================================
- Hits 890 880 -10
- Misses 76 142 +66
- Partials 43 45 +2
Continue to review full report at Codecov.
|
@arpitBhalla this looks great! The only issue I see is that when I try it out on iOS, pressing anywhere on the screen opens the menu. That seems to be incorrect. Not sure if that's because of the demo app code or the component itself. |
@flyingcircle Kindly Review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Done
@flyingcircle Kindly Review |
I test in iOS and I still had a weird experience. When I had the menu open and I clicked to the left of a button in the Speed Dial, the menu didn't close, but if I clicked anywhere else on the screen, then it did close. It looks like there's a couple of transparent boxes that are blocking the backdrop Press from triggering. |
|
@flyingcircle I have tested in both android and iOS, I hope this time it will run smooth 😯 |
Summary
Fixing #2880
https://material.io/components/buttons-floating-action-button#types-of-transitions
https://material-ui.com/components/speed-dial/#speed-dial
SpeedDial.mp4