Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added New Component: Speed dial #2896

Merged
merged 17 commits into from
Apr 4, 2021

Conversation

arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Mar 22, 2021

@arpitBhalla
Copy link
Member Author

@flyingcircle Kindly Review

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #2896 (8807fa1) into next (d78718c) will decrease coverage by 5.73%.
The diff coverage is 56.08%.

❗ Current head 8807fa1 differs from pull request most recent head daba5c5. Consider uploading reports for the commit daba5c5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             next    #2896      +/-   ##
==========================================
- Coverage   88.20%   82.47%   -5.74%     
==========================================
  Files          50       51       +1     
  Lines        1009     1067      +58     
  Branches      399      408       +9     
==========================================
- Hits          890      880      -10     
- Misses         76      142      +66     
- Partials       43       45       +2     
Impacted Files Coverage Δ
src/header/Header.tsx 73.07% <ø> (ø)
src/buttons/SpeedDial.tsx 55.00% <55.00%> (ø)
src/slider/Slider.tsx 58.91% <56.25%> (-29.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d78718c...daba5c5. Read the comment docs.

@flyingcircle
Copy link
Collaborator

@arpitBhalla this looks great! The only issue I see is that when I try it out on iOS, pressing anywhere on the screen opens the menu. That seems to be incorrect. Not sure if that's because of the demo app code or the component itself.

@arpitBhalla
Copy link
Member Author

@flyingcircle Kindly Review

@arpitBhalla arpitBhalla marked this pull request as draft March 26, 2021 15:40
@arpitBhalla arpitBhalla marked this pull request as ready for review March 26, 2021 15:53
Copy link
Member Author

@arpitBhalla arpitBhalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Done

src/buttons/SpeedDial.tsx Outdated Show resolved Hide resolved
@arpitBhalla
Copy link
Member Author

@flyingcircle Kindly Review

@flyingcircle
Copy link
Collaborator

I test in iOS and I still had a weird experience. When I had the menu open and I clicked to the left of a button in the Speed Dial, the menu didn't close, but if I clicked anywhere else on the screen, then it did close. It looks like there's a couple of transparent boxes that are blocking the backdrop Press from triggering.

@arpitBhalla
Copy link
Member Author

arpitBhalla commented Apr 4, 2021

I test in iOS and I still had a weird experience. When I had the menu open and I clicked to the left of a button in the Speed Dial, the menu didn't close, but if I clicked anywhere else on the screen, then it did close. It looks like there's a couple of transparent boxes that are blocking the backdrop Press from triggering.

elevation might not be working in iOS

@arpitBhalla
Copy link
Member Author

@flyingcircle I have tested in both android and iOS, I hope this time it will run smooth 😯

@flyingcircle flyingcircle merged commit 7fdec69 into react-native-elements:next Apr 4, 2021
@arpitBhalla arpitBhalla deleted the speedDial branch April 5, 2021 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants