Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added New Component: TabView #2919

Merged
merged 9 commits into from Apr 12, 2021

Conversation

arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Mar 26, 2021

@arpitBhalla arpitBhalla marked this pull request as draft March 26, 2021 08:09
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #2919 (fd40427) into next (19566ea) will decrease coverage by 0.34%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #2919      +/-   ##
==========================================
- Coverage   79.65%   79.31%   -0.35%     
==========================================
  Files          52       53       +1     
  Lines        1111     1131      +20     
  Branches      444      449       +5     
==========================================
+ Hits          885      897      +12     
- Misses        174      182       +8     
  Partials       52       52              
Impacted Files Coverage Δ
src/tab/tab.tsx 60.00% <60.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19566ea...fd40427. Read the comment docs.

@flyingcircle
Copy link
Collaborator

How is this different from ButtonGroup?

@arpitBhalla
Copy link
Member Author

arpitBhalla commented Mar 26, 2021

Tabs:
FWojY
ButtonGroup
AFgz0

@arpitBhalla
Copy link
Member Author

@flyingcircle Should I continue on this?

@flyingcircle
Copy link
Collaborator

I think as an alternative styling of ButtonGroup this could be a nice simple addition. Sure.

@arpitBhalla arpitBhalla marked this pull request as ready for review March 29, 2021 12:32
@arpitBhalla
Copy link
Member Author

@flyingcircle Please Review

@arpitBhalla arpitBhalla marked this pull request as draft April 11, 2021 11:40
src/index.ts Outdated Show resolved Hide resolved
@arpitBhalla arpitBhalla marked this pull request as ready for review April 12, 2021 04:11
@flyingcircle flyingcircle merged commit 5c2d6b6 into react-native-elements:next Apr 12, 2021
@arpitBhalla arpitBhalla deleted the tabView branch April 13, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants