Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Redesigned #3108

Merged
merged 12 commits into from
Jun 29, 2021
Merged

Conversation

arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Jun 25, 2021

Closes #3015
Preview https://rne-docs.surge.sh/

HomePage

scrnli_26_06_2021_18-27-36

Tabs:

image

Expo Snack:

Screenshot from 2021-06-25 23-56-39

Tips

image

@arpitBhalla arpitBhalla marked this pull request as draft June 25, 2021 13:44
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #3108 (2719e59) into next (34c6936) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #3108   +/-   ##
=======================================
  Coverage   83.84%   83.84%           
=======================================
  Files          78       78           
  Lines        1684     1684           
  Branches      669      669           
=======================================
  Hits         1412     1412           
  Misses        268      268           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34c6936...2719e59. Read the comment docs.

@khushal87
Copy link
Member

Make sure you don't change the directory structure of the docs as mentioned in this screenshot https://user-images.githubusercontent.com/55053424/123469721-0a44c800-d611-11eb-8b92-397ab1affba3.png for now. You can do it later.

@khushal87
Copy link
Member

Hompage renovation is a great idea, but don't add additional restructuring of the docs in the same PR, it's difficult to track these changes and when it's merged, If you do it same PR. Please raise different PRs for different changes or do add a detailed description.

@arpitBhalla arpitBhalla marked this pull request as ready for review June 26, 2021 13:42
@arpitBhalla arpitBhalla changed the title [website] Homepage renovate [website] Redesigned Jun 26, 2021
@arpitBhalla
Copy link
Member Author

Make sure you don't change the directory structure of the docs as mentioned in this screenshot https://user-images.githubusercontent.com/55053424/123469721-0a44c800-d611-11eb-8b92-397ab1affba3.png for now. You can do it later.

Okay, I will do accordingly @khushal87

@flyingcircle flyingcircle merged commit 3c4ea50 into react-native-elements:next Jun 29, 2021
@arpitBhalla arpitBhalla deleted the website branch June 29, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Redesign Homepage of website
3 participants