Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Latest merge issues #3143

Merged
merged 2 commits into from Jul 16, 2021

Conversation

khushal87
Copy link
Member

@khushal87 khushal87 commented Jul 16, 2021

This PR fixes:

  • The name of the package in package.json. This was changed mistakenly. Looking for speedy review and merge.
  • Updated the ButtonGroup tests which were not running.

@arpitBhalla
Copy link
Member

arpitBhalla commented Jul 16, 2021

ReferenceError: useBaseUrl is not definedReferenceError: useBaseUrl is not defined
(undefined) ReferenceError: useBaseUrl is not defined

docs build is showing this. can you check

https://github.com/react-native-elements/react-native-elements/runs/3078177434?check_suite_focus=true

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (next@38b5dbb). Click here to learn what that means.
The diff coverage is 81.42%.

❗ Current head b96895a differs from pull request most recent head f2e5aca. Consider uploading reports for the commit f2e5aca to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             next    #3143   +/-   ##
=======================================
  Coverage        ?   83.87%           
=======================================
  Files           ?       78           
  Lines           ?     1687           
  Branches        ?      666           
=======================================
  Hits            ?     1415           
  Misses          ?      268           
  Partials        ?        4           
Impacted Files Coverage Δ
src/AirbnbRating/AirbnbRating.tsx 0.00% <0.00%> (ø)
src/PricingCard/components/PricingButton.tsx 100.00% <ø> (ø)
src/Rating/Rating.tsx 0.00% <ø> (ø)
src/SearchBar/SearchBar-android.tsx 98.30% <ø> (ø)
src/SearchBar/SearchBar-default.tsx 95.74% <ø> (ø)
src/SearchBar/SearchBar-ios.tsx 89.70% <ø> (ø)
src/SearchBar/SearchBar.tsx 100.00% <ø> (ø)
src/SearchBar/__tests__/common.tsx 100.00% <ø> (ø)
src/Slider/Slider.tsx 60.47% <ø> (ø)
src/Slider/components/Rect.tsx 45.45% <ø> (ø)
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38b5dbb...f2e5aca. Read the comment docs.

@khushal87 khushal87 changed the title [Fix] package.json name [Fix] Latest merge issues Jul 16, 2021
@flyingcircle flyingcircle merged commit 393aa6e into react-native-elements:next Jul 16, 2021
@khushal87 khushal87 deleted the khushal87-dev1 branch July 16, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants