-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Refactor Input Component #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -0,0 +1,117 @@ | |||
import PropTypes from 'prop-types'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the file that needs to be reviewed.
Also here are some cool UI designs to port over using RNE: https://www.pinterest.com/timoa/mobile-ui-logins/ $50 🤑 for anyone wanting to contribute and create an entire screen |
@Monte9 Maybe select some, out of the bunch? |
@iRoachie that's a good point. Here are the ones that I think look good/can be a bit challenging to implement.
|
@Monte9 Is it only the text fields you're interested in? |
@Monte9 Oh so screens to put in the showcase? I can make them, just wondering what was reasoning behind it. |
@iRoachie exactly. The idea is to help developers bootstrap their RN app can by giving them an "unfair" advance as they can literally copy a screen from our showcase app and built on top of it. And on the flip side, any dev that creates these screens and contributes back to RNE, will be getting paid $50/screen for it. So it's a win-win. It would be awesome if you can create the first screen and kick this idea off. 😉 |
Will take a jab after release 0.14 |
@xavier-villelegier @martinezguillaume is this something you guys would be interested in? ^^ |
@Monte9 Sure, we'll try to look into it this week. It can be a good showcase of what can be done with RNE. On which branch should we be based to have those new components ( |
Alright, the Also there are lots of opportunities to help out with this if anyone is interested. Please see this: https://github.com/react-native-training/react-native-elements/projects/4 Merging this PR into |
@xavier-villelegier all the latest changes are on the Also the idea is to basically create entire screens for the app (login view/sign up view/feed view/profile view) using You can see all the available tasks here: https://github.com/react-native-training/react-native-elements/projects/4 /cc @iRoachie @martinezguillaume ^^ |
@Monte9 Gotcha will chip in after the release. Release notes are fun :D |
Major Breaking changes
Please see the
/example
app for the above implementation.Really simple and useful API:
Also handles 3 TextInput functions: