Make default props optional in type definition #614
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
this helps in unnecessary typescript errors while creating a wrapper component
Test Plan
suppose we create a warpper for modal component with app specific default props like below
you will see typescript error "TS2783: 'hideModalContentWhileAnimating' is specified more than once, so this usage will be overwritten."
when you use component with optional call backs from parent like below
this.props.onModalShowis optionalyou will see typescript error "TS2322: Type '(() => void) | undefined' is not assignable to type '() => void'. Type 'undefined' is not assignable to type '() => void'."