Skip to content

Conversation

@cpjolicoeur
Copy link
Contributor

fbemitter should be a dependency not a peerDependency of this project because this project actually includes/requires it for internal usage.

Also, peerDependencies are just completely broken in all kinds of ways currently for npm 2 and npm 3

@cpjolicoeur cpjolicoeur changed the title Make fbemitter an actuall dependency Make fbemitter an actual dependency Feb 3, 2016
@ericraio
Copy link
Contributor

ericraio commented Feb 4, 2016

@cpjolicoeur there is talks about removing fbemitter all together and use react native's EventEmitter

@SEthX do you know how to implement that? I was a little confused.

@davidLeonardi
Copy link
Contributor

Yes i have a pretty good idea on how to do that.
Ill take care of it, on saturday most likely.
On Thu, 4 Feb 2016 at 07:14, Eric Raio notifications@github.com wrote:

@cpjolicoeur https://github.com/cpjolicoeur there is talks about
removing fbemitter all together and use react native's EventEmitter

@SEthX https://github.com/sethx do you know how to implement that? I
was a little confused at first.


Reply to this email directly or view it on GitHub
#23 (comment)
.

@cpjolicoeur
Copy link
Contributor Author

Sounds good. I just wanted to open the PR because the current release isn't usable as is with the current npm versions without forking and fixing.

Thanks for the quick response.

davidLeonardi added a commit that referenced this pull request Feb 4, 2016
Make fbemitter an actual dependency
@davidLeonardi davidLeonardi merged commit a53230a into react-native-simple-router-community:master Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants