Skip to content

Add Material design style #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2016
Merged

Add Material design style #25

merged 1 commit into from
Feb 7, 2016

Conversation

@charpeni
Copy link
Contributor

@charpeni charpeni commented Feb 4, 2016

  • Split specific styles files into styles.ios.js and styles.android.js.
  • Add Material design styles (not exact as described in guidelines).
    • Height of 56.
    • Align the text to the left.
    • Remove margin top.
    • Add margin bottom.
  • If they are empty, leftCorner and rightCorner doesn't take any space for layout purposes.
  • Nav bar title can now be full width when leftCorner and rightCorner are empty.

I'm not sure about the method that I used, feel free to comment !

@charpeni charpeni mentioned this pull request Feb 4, 2016
Closed
2 tasks
davidLeonardi added a commit that referenced this pull request Feb 7, 2016
@davidLeonardi
Merge pull request #25 from charpeni/issue-12
f2b93ae 
Add Material design style
@davidLeonardi davidLeonardi merged commit f2b93ae into react-native-simple-router-community:master Feb 7, 2016
@charpeni charpeni deleted the issue-12 branch March 1, 2016 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charpeni @davidLeonardi