Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example #623

Open
wants to merge 4 commits into
base: master
from
Open

Conversation

@DimitrisTzimikas
Copy link

DimitrisTzimikas commented Apr 11, 2019

This is a working example that uses the current API. The only thing it does is to configure the devices media and display the from camera (or rear) stream to the RTCView. It also give access to RTCView props "change camera', 'mirror' and 'object fit' option.

Its configured only for Android.

EDIT:
I configured the iOS and build successfully but only on emulator. I'll test it atMonday on a real device. Maybe it would be better to wait until then to pull then with working configuration for both iOS/Android.

@DimitrisTzimikas

This comment has been minimized.

Copy link
Author

DimitrisTzimikas commented Apr 16, 2019

@saghul Final example, working on Android & iOS

buildscript {
ext {
buildToolsVersion = "28.0.3"
minSdkVersion = 16

This comment has been minimized.

Copy link
@aghahuseynov

This comment has been minimized.

Copy link
@aghahuseynov

aghahuseynov Mar 4, 2020

I think the following versions of Android 24 are not supported or I couldn't run

This comment has been minimized.

Copy link
@saghul

saghul Mar 4, 2020

Member

It must be something else. We use 19 with no problems. 16 is indeed too old, Google no longer supports it.

This comment has been minimized.

Copy link
@piranna

piranna Mar 4, 2020

Contributor

16 is the minimum version needed by ReactNative itself, newer versions would be needed by specific native modules if they use more recent APIs, but they would need to specify it in their docs.

This comment has been minimized.

Copy link
@aghahuseynov

aghahuseynov Mar 4, 2020

I get this error when I make minSDK 23 in the project.
Ekran Resmi 2020-03-04 11 36 39

But minSdk 24 is running on my projecet

This comment has been minimized.

Copy link
@aghahuseynov

aghahuseynov Mar 4, 2020

YES it is worked! Thanks for support. Can you write about the "code" ?

This comment has been minimized.

Copy link
@saghul

saghul Mar 4, 2020

Member

What "code" ?

This comment has been minimized.

Copy link
@aghahuseynov

aghahuseynov Mar 4, 2020

android.enableDexingArtifactTransform.desugaring=false

This comment has been minimized.

Copy link
@saghul

saghul Mar 4, 2020

Member

What is the question? This disables some ccode transformations that seem to break WebRTC. It started to appear with the gradle plugin 3.5.0.

This comment has been minimized.

Copy link
@aghahuseynov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.