New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitioner mounting umbrella issue #4155

Closed
brentvatne opened this Issue May 7, 2018 · 6 comments

Comments

Projects
None yet
5 participants
@brentvatne
Member

brentvatne commented May 7, 2018

The Transitioner, used by stack navigator, can in some cases where the user executes a back action and then navigate action quickly (to anywhere, not to return to the same screen) in succession, may remount the screen we went back from and unmount it again.

The Transitioner rewrite we are planning for v3 should address this.

@msageryd

This comment has been minimized.

msageryd commented Sep 13, 2018

@brentvatne Are there any official plans for v3? I've had to implement some nasty workarounds for the componentDidMount issue (called when navigating back from a screen).

It would be really great to be able to trust that the events are called only when appropriate.

@aksonov

This comment has been minimized.

aksonov commented Sep 24, 2018

@brentvatne Any fix/workaround for v2? We use Transitioner with custom animations and it remounts popped components after 'back' action (i.e. scene.index > current index) (but some components with the same animations/setup are processed correctly)

@brentvatne

This comment has been minimized.

Member

brentvatne commented Sep 24, 2018

there is no solution right now. someone needs to dig in and rewrite the Transitioner component. this is kind of difficult to do... but if you're up for it :P

@brentvatne

This comment has been minimized.

Member

brentvatne commented Oct 29, 2018

@xy371661665

This comment has been minimized.

xy371661665 commented Oct 30, 2018

@brentvatne But it can't use that the version 3.0.0-alpha.15

@brentvatne

This comment has been minimized.

Member

brentvatne commented Oct 31, 2018

we'll release a rc soon with instructions for how you can use it

@brentvatne brentvatne closed this Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment