Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for when people use drawer navigator inside tab navigator #4714

Closed
brentvatne opened this issue Jul 18, 2018 · 3 comments
Closed

Comments

@brentvatne
Copy link
Member

This doesn't work on Android currently and nobody is working on fixing that at the moment, so we should warn. #4154

@daviscabral
Copy link

@brentvatne would you consider accept a PR that fixes that? Just checking before considering workarounds in other libs that consumes react-navigation.

@brentvatne
Copy link
Member Author

in https://github.com/react-navigation/react-navigation-drawer/tree/next i switched to using drawerlayout from react-native-gesture-handler, and that should resolve the issue, but I haven't verified that yet

@brentvatne
Copy link
Member Author

i believe it's fixed but created an issue to verify it here: https://github.com/react-navigation/react-navigation-drawer/issues/21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants