New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary navigation completion dispatches #3902

Merged
merged 1 commit into from Apr 5, 2018

Conversation

Projects
None yet
4 participants
@ericvicenti
Contributor

ericvicenti commented Apr 4, 2018

There is an excess of dispatched events coming from this, because "onTransitionEnd" will happen even after immediate transitions.

This ensures that the completion action is only dispatched when it is explicitly needed

@ericvicenti ericvicenti force-pushed the @ericvicenti/completedispatch branch from 6b78f14 to d2fe180 Apr 4, 2018

@react-navigation-ci

This comment has been minimized.

@react-navigation-ci

This comment has been minimized.

@codecov-io

This comment has been minimized.

codecov-io commented Apr 4, 2018

Codecov Report

Merging #3902 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3902      +/-   ##
==========================================
- Coverage   69.26%   69.22%   -0.04%     
==========================================
  Files          57       57              
  Lines        1734     1735       +1     
==========================================
  Hits         1201     1201              
- Misses        533      534       +1
Impacted Files Coverage Δ
src/views/StackView/StackView.js 55.55% <0%> (-6.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57d118...d2fe180. Read the comment docs.

@brentvatne brentvatne merged commit bbacabe into master Apr 5, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@brentvatne brentvatne deleted the @ericvicenti/completedispatch branch May 7, 2018

Christian-Athom added a commit to athombv/react-navigation that referenced this pull request Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment