New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./src/createNavigationContainer -> @react-navigation/native/src/createAppContainer on NavigationTestUtils.js #5266

Merged
merged 2 commits into from Nov 26, 2018

Conversation

Projects
None yet
3 participants
@watanabeyu
Contributor

watanabeyu commented Nov 22, 2018

Motivation

Explain the motivation for making this change. What existing problem does the pull request solve?

For App-test.js on expo.
I updated react-navigation to v3, and want to test navigation, but error was occured.
So replace it.

Test plan

Demonstrate the code is solid. Example: the exact commands you ran and their output, screenshots / videos if the pull request changes UI.

Make sure you test on both platforms if your change affects both platforms.

The code must pass tests.

Code formatting

Lint-Staged handled

Changelog

  • Add an entry under the "Unreleased" heading in CHANGELOG.md which explains your change.
@react-navigation-ci

This comment has been minimized.

@brentvatne brentvatne merged commit 0641bdd into react-navigation:master Nov 26, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@brentvatne

This comment has been minimized.

Member

brentvatne commented Nov 26, 2018

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment