Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to style-components v4 #1

Open
gabrielmoncea opened this issue Feb 18, 2019 · 5 comments
Open

Update to style-components v4 #1

gabrielmoncea opened this issue Feb 18, 2019 · 5 comments

Comments

@gabrielmoncea
Copy link

@gabrielmoncea gabrielmoncea commented Feb 18, 2019

I think this package will benefit a lot if it is updated to styled-components v4

@diegomura

This comment has been minimized.

Copy link
Contributor

@diegomura diegomura commented Feb 18, 2019

Thanks! I'm not that familiar with v4 changes. Could you explain a bit further why you think is that?

@gabrielmoncea

This comment has been minimized.

Copy link
Author

@gabrielmoncea gabrielmoncea commented Feb 18, 2019

From what I understand v4 is smaller, but also mounts faster due to some refactoring and optimisations around memory usage and JS engine implementation details.

@diegomura

This comment has been minimized.

Copy link
Contributor

@diegomura diegomura commented Feb 18, 2019

Ok. Sounds good!
I'll try to take a look at this soon, but I still have some other issues to tackle before this 😅 .
Feel free to jump on this if you like!

@gabrielmoncea

This comment has been minimized.

Copy link
Author

@gabrielmoncea gabrielmoncea commented Feb 19, 2019

One nice issue that I can't do, is the support of SVGs for react-pdf :)

@diegomura

This comment has been minimized.

Copy link
Contributor

@diegomura diegomura commented Feb 22, 2019

I just checked this, and it wouldn't be that simple to implement. The main cause is that styled-components v4 does not export the lib dir but just the bundles. I'm not going to work on this in the near future, so if someone feels like tackling this, please do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.