Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: Rendering <Context.Consumer.Consumer> is not supported #9

Closed
nathanstitt opened this issue Nov 8, 2018 · 4 comments
Closed

Comments

@jquense

This comment has been minimized.

Copy link
Member

@jquense jquense commented Nov 10, 2018

ya I raise my hand in defeat for providing a more flexible api :P I think what needs to happen is the RCT just needs to only accept the base Context object, like the new useContext hook does. We should update references in react-bootstrap to just use the Context

nathanstitt added a commit to nathanstitt/react-bootstrap that referenced this issue Nov 11, 2018
As outlined in react-restart/context#9, context toolbox
needs to only use Context.Consumer since it can't
navigate to the Consumer property reliably.
@nathanstitt

This comment has been minimized.

Copy link
Author

@nathanstitt nathanstitt commented Nov 11, 2018

Thanks @jquense yes, I think that's best. I was going to make a PR to do so but I think you can just revert fb0262a

I updated react-bootstrap to always pass in Context.Consumer in react-bootstrap/react-bootstrap#3368

@nathanstitt

This comment has been minimized.

Copy link
Author

@nathanstitt nathanstitt commented Nov 12, 2018

And thanks to react-bootstrap/react-bootstrap#3368 (comment) I realize I completely mis-read your comment @jquense. I'll update the PR above to pass in Context instead of Context.Consumer.

nathanstitt added a commit to nathanstitt/react-bootstrap that referenced this issue Nov 12, 2018
As outlined in react-restart/context#9, context toolbox
needs to only use only Context, not Context.Consumer
jquense added a commit to react-bootstrap/react-bootstrap that referenced this issue Nov 13, 2018
…3368)

As outlined in react-restart/context#9, context toolbox
needs to only use only Context, not Context.Consumer
@nathanstitt

This comment has been minimized.

Copy link
Author

@nathanstitt nathanstitt commented Nov 13, 2018

PR was merged into bootstrap, so we can close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.