Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid .cjs.js imports for @react-spring/shared #730

Closed
nhardy opened this issue Jul 1, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@nhardy
Copy link

commented Jul 1, 2019

馃悰 Bug Report

It looks like 274afad introduced an issue with CommonJS imports. @react-spring/shared does not currently have a rollup config that would output .cjs.js files, yet these are now being referenced as a result of that change.

I've added a comment to the beta feedback issue already.

To Reproduce

Steps to reproduce the behavior:

Install v9.0.0-beta.28 and use a commonjs entrypoint. This will then complain about being unable to resolve @react-spring/shared/global.cjs.js as this file does not exist.

Environment

  • react-spring v9.0.0-beta.28
  • react v16.8.6

@nhardy nhardy added the bug label Jul 1, 2019

@aleclarson

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

Thanks for the bug report! I'm gonna revert that commit and publish a new beta. 馃憤

@aleclarson aleclarson closed this Jul 1, 2019

@aleclarson aleclarson added the v9 label Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.