Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devAssetsPath and stagingAssetsPath #1208

Merged
merged 3 commits into from Jul 9, 2019

Conversation

Projects
None yet
3 participants
@kalinchuk
Copy link
Contributor

commented May 28, 2019

Description

Adds devAssetsPath and stagingAssetsPath to config.

Changes/Tasks

Motivation and Context

This enables the usage of a staging assets CDN instead of using a single CDN for all environments.

Types of changes

  • Refactoring/add tests (refactoring or adding test which isn't a fix or add a feature)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have updated the documentation accordingly
  • I have updated the CHANGELOG with a summary of my changes
  • My changes have tests around them

Artem Kalinchuk added some commits May 28, 2019

@tannerlinsley

This comment has been minimized.

Copy link
Collaborator

commented Jun 7, 2019

Could you pull in changes from master? There were a few little things that were added in previous commits that were just merged. This is looking good!

@sw-yx

This comment was marked as resolved.

Copy link
Collaborator

commented Jul 9, 2019

hi everyone! thanks for your PR! there is now a call for maintainers of React Static, please weigh in here: #1259

@sw-yx sw-yx merged commit 9e169e6 into react-static:master Jul 9, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.