Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 7.2.0 maintenance #1293

Merged
merged 24 commits into from Sep 1, 2019

Conversation

@SleeplessByte
Copy link
Contributor

commented Sep 1, 2019

  • Set-up workspace
  • Document setting up workspace
  • Update minor and patch dependencies
  • Attempt dependency updates where they are breaking (major updates)
  • Update version information, repository and author
  • Update CHANGELOG.md
  • Test against test-suite
  • Test against production builds (locally)
  • Update documentation where appropiate
  • Publish to npm

Note to self: Locally I have 2 failing tests,

  • One of which is a cross-env windows test (so the code is actually correct, but the test doesn't account for different pathing structures). Edit: confirmed. Works on linux
  • The other one seems to be related to updating chokidar past a major version. Downgrade it , re-run and then figure out if there is a path where we can upgrade past a major version.

Note to self: since the hardcoded overrideBrowserslist is working, it can now be removed. browserlists will fall back to defaults if there is no config. It's technically breaking, but also a bug, so it will be released in this minor change.

  • remove "hardcoded fix" from 7c244e4, relying on auto-resolution of the config
  • add documentation how to resolve the mismatch between the old defaults and the new defaults, by telling users of react-static to add the config to their project.

Note to self:

  • investigate build on windows vs linux. Dev mode 铆s working, build seems to hang. Run with debug on. Probably minor cross env pathing thing.

Note to self:

  • can't seem to fix the super weird chokidar issue. path, the node module, for some reason, does not have the right exports. Works fine when isolated in a different project.
  • --debug build works. No errors! Why does it hang without this flag?
SleeplessByte added 19 commits May 12, 2019
Switch to data-prefetch
The prefetch attribute is not an attribute on anchor elements. The preferred way to do custom attributes is using data-* attributes or custom web elements.

When using anchor attributes the only potential candidate would be rel="prefetch", but that is not enabled for anchor elements (only link elements):

https://developer.mozilla.org/en-US/docs/Web/HTTP/Link_prefetching_FAQ
Add missing configuration
This is a dependency from eslint-config-react-tools but not listed in the dependencies of that package.
Use browsers configuration from project
This removes the hardcoded browserlists by injecting them from the root path.

This is a "sorta breaking" change, as it changes the defaults from:
- >1%,
- last 4 versions,
- Firefox ESR,
- not ie < 9

To:

- > 0.5%
- last 2 versions
- Firefox ESR
- not dead

Since this is also a bug, it will be released with the minor release. Adding `browserslist` to your package.json or a config file, instantly fixes this.

#closes #1126
Remove hardcoded fix
The fix works, which means that the browserlist functionality works. It now pulls it automaticaly from the project (user project) config, or defaults to "defaults".
Bump packages and add devPeers
It's common to add peerDependencies as devDependencies. This way, they _will_ be installed on development and thus you can test as if they're really there.

Some of the peerDependencies were missing in the first place.

Additionally, during development, we want to use the local react-static folder module, which is symlinked.
Remove mapped names, update mocks and fix tests
Now that the configuration returns absolute paths, this updates the tests to also "mock" absolute paths.

@SleeplessByte SleeplessByte self-assigned this Sep 1, 2019

@SleeplessByte SleeplessByte referenced this pull request Sep 1, 2019
5 of 10 tasks complete
Update urls to use react-static
Nozzle is no longer owning this repository.

@SleeplessByte SleeplessByte merged commit dbf750c into master Sep 1, 2019

5 of 7 checks passed

Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 5 redirect rules processed
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
deploy/netlify Deploy preview ready!
Details

@SleeplessByte SleeplessByte deleted the release/7.2.0-maintenance branch Sep 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.