Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix images #1305

Merged

Conversation

@krzysztof-pyrzyk-ah
Copy link
Contributor

commented Sep 9, 2019

This PR fixes an issue with missing images.

Motivation and Context

#1304

Types of changes

  • Refactoring/add tests (refactoring or adding test which isn't a fix or add a feature)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
@Pixelatex

This comment has been minimized.

Copy link
Collaborator

commented Sep 11, 2019

If your changes are binary file changes -> not really reviewable via the github interface.

Could you mention what you changed/how/why/what the issue was in your description?

@krzysztof-pyrzyk-ah

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

Ahh, yes, sorry for not describing the PR enough in the first place.

So here is the issue it solves: #1304
And what I did was basically a revert of 311cd1d

When you guys pushed new React-Static version with new line endings (CRLF instead of LF) some images got broken so I've just reverted them to the previous state 😬

@SleeplessByte SleeplessByte merged commit 42f14d6 into react-static:master Sep 25, 2019
4 of 6 checks passed
4 of 6 checks passed
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 5 redirect rules processed
Details
Travis CI - Pull Request Build Passed
Details
deploy/netlify Deploy preview ready!
Details
@SleeplessByte

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2019

You're the best! That was exactly the fix I wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.